ilteoood / flutter_i18n

I18n made easy, for Flutter!
MIT License
217 stars 57 forks source link

feat: Try to loads translations from the remote resource. If offline … #181

Closed hendrickpras closed 2 years ago

hendrickpras commented 2 years ago

…or failed, then loads translation files from local path.

ilteoood commented 2 years ago

Hi @hendrickpras, IMO you should use the loaders that we already have, to make this feature.

I suggest to not re-create custom logic, in order to keep them simple.

Also, tests are missing.

ilteoood commented 2 years ago

What you are doing is OK, if you want to implement it from scratch, but in this case you should use the loaders that we already have.