Support for list at least for json

ilteoood / flutter_i18n

I18n made easy, for Flutter!

MIT License

217 stars 57 forks source link

Support for list at least for json #219

Closed Judimax closed 3 months ago

ilteoood commented 6 months ago

Could you add some tests that prove that what you did is correct?

Judimax commented 6 months ago

Greetings I have made the edits as requested I updated the android/app/build.gradle to version 34 to get the andrioid integrations test to pass not sure how that fares with backwards comptability

Judimax commented 6 months ago

the changes

[UPDATE] Updated _decodeFromMap in simple_translator.dart to handle subMap as a dynamic type, reintroducing checks and handling for subMap being a List.
[UPDATE] Modified calculateSubmap in simple_translator.dart to return a dynamic type and reintroduced logic to handle the decodedSubMap as either Map or List, including handling list indexing and nested data structures.

Judimax commented 6 months ago

I appreciate the lazer focus on best coding practices I haven't seen devotion like that in my day to day so I had to dumb it back

Judimax commented 6 months ago

Checking in any updates

ilteoood commented 5 months ago

Hi @Judimax, sorry for being late in the review process.

I don't think that this PR is something that should be merged atm: it complicates the implementation and what you want desire can be achieved using a syntax like:

  'key': {
    '0': 'value'
    ...
  }