Closed rebeccajohnson88 closed 3 years ago
Great. I updated my repository to bring in your changes in and then made a few tiny aesthetic changes in this commit.
Then I ran the code and updated BuchmannDiPrete_output.txt and gss_fourPanel.pdf in Overleaf.
Commit here
Looks good! Only small question/possible change (changed in above commit and it produces nearly identical results but with some small diff in ~4th sig dig of p value is:
Does the filtering out of irrelevant cohorts restriction, then adjusts weights per mgcv doc to divide weight by mean, then does further analytic restriction to remove those missing any of relevant covars
It seems like the weights adjustment might be better to do after all sample restrictions so in updated code just changed order of that step to be after the second-round filters, but not positive that's correct