Java random numbers implementation - Githubissues

iluwatar / 30-seconds-of-java

Collection of reusable tested Java 17 compatible code snippets that you can understand in 30 seconds or less.

https://java-design-patterns.com/snippets.html

MIT License

1.04k stars 410 forks source link

Java random numbers implementation #202

Closed Shanty97 closed 8 months ago

Shanty97 commented 9 months ago

Random Number between X and Y

Added Code for generating a random number between given x(inclusive) and y(inclusive)
Covered data types are byte, short, integer, long, float and double
Added and ran unit tests covering all datatypes

Throw A Dice (eg. 3d6)

Added code for generating the total sum from the given number of dice and number of sides
Added an Enum for covering the standard dice sides: 4, 6, 8, 10
Added and ran unit tests covering all dice sides

Test Report

Test-Report

CheckStyle Report - Main

CheckStyle-Main

CheckStyle Report - Test

CheckStyle-Test

sonarcloud[bot] commented 8 months ago

Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

iluwatar commented 8 months ago

Looks great! Thank you for the contribution 🎉

Shanty97 commented 8 months ago

@iluwatar My pleasure !