search

iluwatar / java-design-patterns-vuepress-web

Next generation website for Java Design Patterns
https://java-design-patterns.com
MIT License
261 stars 63 forks source link

Theme button #67

Closed GiulioBernardi closed 1 year ago

GiulioBernardi commented 1 year ago

The theme button is having a strange behaviour when clicked. It looks like it initial state is the oposite one that is beeing applied to the website, and then when you change it, it does not apply any theme changes because theme is already applied.

Gif bellow button-state

iluwatar commented 1 year ago

I think the initial state is "automatic". It switches between light and dark modes based on the time of day. The other states are light and dark.

GiulioBernardi commented 1 year ago

Well. It makes sense now that you said about the time of day based behaviour.