search

iluwatar / java-design-patterns

Design patterns implemented in Java
https://java-design-patterns.com
Other
89.25k stars 26.41k forks source link

Executable jar problem #2565

Open iluwatar opened 1 year ago

iluwatar commented 1 year ago

The project includes Maven Assembly plugin to produce executable jars out of all the submodules (individual patterns). However, there currently seems to be a problem with the intended behaviour.

Steps to reproduce:

  1. At the project root build everything, i.e. mvn clean package -DskipTests=true
  2. Execute one of the produced jars, e.g. java -jar spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar

Expected behaviour

Actual behavior

satyajitbhatt commented 1 year ago

Hello @iluwatar Can you give me chance to solve above issue ? If yes then I'm willing to contribute over here and want to help you to solve executable jar problem.

Thank you in advance

Sujoydas001 commented 11 months ago

Can I have a look here ?

iluwatar commented 11 months ago

@satyajitbhatt are you working on it?

satyajitbhatt commented 11 months ago

No, I am not.

On Sun, Sep 24, 2023, 8:49 PM Ilkka Seppälä @.***> wrote:

@satyajitbhatt https://github.com/satyajitbhatt are you working on it?

— Reply to this email directly, view it on GitHub https://github.com/iluwatar/java-design-patterns/issues/2565#issuecomment-1732595463, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQA37LBSGJBBQPEG7M7L453X4BFPXANCNFSM6AAAAAA3XDA7MQ . You are receiving this because you were mentioned.Message ID: @.***>

Navneetsinghnegi commented 11 months ago

@iluwatar I want to go through the issue and work upon it

BrijeshPatra commented 11 months ago

Hi @iluwatar here we have 2 approaches to solve this bug a) add the name of main class to the jar file b) create the jar file as an executable jar

BrijeshPatra commented 11 months ago

I am trying hard to contribute but getting an error Unable to access jarfile spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar. It would be helpful if you review it once and suggest me something better @iluwatar

BrijeshPatra commented 11 months ago
Bug
iluwatar commented 11 months ago

Assigned to @Navneetsinghnegi

Aniket-kumar404 commented 11 months ago

I would Like to work on this issue.

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

emcconnell27 commented 2 months ago

Hi @iluwatar, could please have a go at solving this issue?

stale[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.