search

iluwatar / java-design-patterns

Design patterns implemented in Java
https://java-design-patterns.com
Other
89.53k stars 26.47k forks source link

Fix high severity issues reported by SonarCloud #2865

Open iluwatar opened 6 months ago

iluwatar commented 6 months ago

SonarCloud is used for static code analysis. It currently reports 48 high severity issues.

See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

It is possible to run the same analysis on local machine using SonarLint plugin. See instructions at https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

Acceptance criteria

iluwatar commented 5 months ago

Most of the high severity issues fixed by @k1w1dev, but still 18 remain. See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

krishnagjsForGit commented 3 months ago

I can start on these remaining issues.

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

PALASH2201 commented 1 day ago

I'm new here, are all the issues fixed?

PALASH2201 commented 1 day ago

I went to through this analysis https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns , mongoDB credentials were hardcoded, so I have added .env file and tested the changes, I have also added and updated dependencies in pom.xml. I have tested and it has passed. How to proceed now?

PALASH2201 commented 1 day ago

Should I issue a PR for your review?

PALASH2201 commented 3 hours ago

@iluwatar I apologize for pinging you, but is this issue solved already, I have made some changes, just need your approval