Changes to make Abstract-Document and Adapter better.

iluwatar / java-design-patterns

Design patterns implemented in Java

https://java-design-patterns.com

Other

88.27k stars 26.19k forks source link

Changes to make Abstract-Document and Adapter better. #2872

Closed drishtii7 closed 3 months ago

drishtii7 commented 3 months ago

What problem does this PR solve?

This PR refactors the Abstract Document by making the variable names more clearer to understand and uses extract method refactoring logic to build a new method called "buildStringRepresentation". It also adds new test cases for better code coverage.

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
9 Security Hotspots
74.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

iluwatar commented 3 months ago

Looks good! Thank you for the contribution 🎉

@all-contributors please add @drishtii7 for code

allcontributors[bot] commented 3 months ago

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

I've put up a pull request to add @drishtii7! :tada: