search

iluwatar / java-design-patterns

Design patterns implemented in Java
https://java-design-patterns.com
Other
88.27k stars 26.19k forks source link

Refactored changes for seperated-interface #2881

Closed drishtii7 closed 2 weeks ago

drishtii7 commented 3 months ago

What problem does this PR solve?

For the method getTaxPercentage introduced in the DomesticTaxCalculator and ForeignTaxCalculator classes, and it's common to both classes. I have pull this method up to a superclass named AbstractTaxCalculator.

iluwatar commented 3 months ago

Seems to contain changes for several patterns. Could you make a separe PR for each?

MaverickWingman commented 3 months ago

hey @drishtii7, The code style does not follow the google style that project use.

See: https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

You can run the checkstyle checks using IDE plugin or using the command line (mvn validate).

stale[bot] commented 2 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 2 weeks ago

Closed due to inactivity. Thank you for your contributions.