search

iluwatar / java-design-patterns

Design patterns implemented in Java
https://java-design-patterns.com
Other
88.25k stars 26.19k forks source link

Fix sonar issues #2925

Closed k1w1dev closed 2 months ago

k1w1dev commented 2 months ago

What problem does this PR solve?

Fixes majority of the high severity issues raised by Sonar. There's a few more left but the changes are already big enough for a review.

Fixes #2865

k1w1dev commented 2 months ago

@iluwatar Hi, would be keen to get some feedback on this whenever you get some time. Thank you :)

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
65.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

iluwatar commented 2 months ago

Looks good! Thank you for the contribution 🎉

@all-contributors please add @k1w1dev for code

allcontributors[bot] commented 2 months ago

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

@k1w1dev already contributed before to code