search

iluxonchik / rfc-bibtex

A command line tool that creates bibtex entries for IETF RFCs and Internet Drafts.
MIT License
44 stars 4 forks source link

added support for parsing LaTeX .aux files and a few automated tests #6

Closed simsong closed 5 years ago

simsong commented 6 years ago

I also made some minor changes to the documentation.

iluxonchik commented 5 years ago

@simsong thank you for your contributions!

I will first merge your changes to an intermediate branch, so that I can fix a few things:

I fell bad for asking you to more things, since you've already done a lot. I will add you as a collaborator, so you should be able to push changes directly if you wish to implement them.

simsong commented 5 years ago

Hi! You are kind. However, the program does what I need at this point. I'm glad I could help! If I need to make more changes, I will do a new clone and push any changes that I need to make! I'm already maintaining too many pieces of code out there.

On Dec 4, 2018, at 12:32 PM, Illya Gerasymchuk notifications@github.com wrote:

@simsong https://github.com/simsong thank you for your contributions!

I will first merge your changes to an intermediate branch, so that I can fix a few things:

if an unexpected RFC format is found within the aux file (ex: RFCabc, it crashes) merging this change as it is, would break the tool's existing functionality: reading RFC's from a list (one per line). I fell bad for asking you to more things, since you've already done a lot. I will add you as a collaborator, so you should be able to push changes directly if you wish to implement them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iluxonchik/rfc-bibtex/pull/6#issuecomment-444186901, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhTrMxJbg7LvRp-FhdEO3kokBETI3R3ks5u1rHCgaJpZM4WwMEU.

iluxonchik commented 5 years ago

Hi! You are kind. However, the program does what I need at this point. I'm glad I could help! If I need to make more changes, I will do a new clone and push any changes that I need to make! I'm already maintaining too many pieces of code out there. … On Dec 4, 2018, at 12:32 PM, Illya Gerasymchuk @.***> wrote: @simsong https://github.com/simsong thank you for your contributions! I will first merge your changes to an intermediate branch, so that I can fix a few things: if an unexpected RFC format is found within the aux file (ex: RFCabc, it crashes) merging this change as it is, would break the tool's existing functionality: reading RFC's from a list (one per line). I fell bad for asking you to more things, since you've already done a lot. I will add you as a collaborator, so you should be able to push changes directly if you wish to implement them. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhTrMxJbg7LvRp-FhdEO3kokBETI3R3ks5u1rHCgaJpZM4WwMEU.

Okay, thank you for your help :smile: