ilya-zlobintsev / LACT

Linux GPU Configuration Tool
MIT License
1.45k stars 34 forks source link

Problems enabling overclocking on nixos #369

Closed robertosw closed 2 months ago

robertosw commented 2 months ago

Checklist

Bug description

Debug snapshot

When enabling OC support, the following warning is displayed. Even though the message says there was a sucess, overclocking is not enabled. Neither at the current boot, nor at next boot. image

I guess this is because the creation of a the file /etc/modprobe.d/99-amdgpu-overdrive.conf is not sucessful, since this is probably a read-only directory in nixos. Or reloading/updating the initramfs fails because of the read-only state.

I am not quite sure if this is a problem of this software or a packaging problem of nixos. If this is only a problem on nixos, I'd suggest that the packaging of the nix-package is change to include the kernel parameter listed under Readme > Overclocking

System info

- LACT version: 0.5.5-release (commit VERGEN_IDEMPOTENT_OUTPUT)
- GPU model: AMD Radeon RX 6800 (0x1002:0x73BF:0xC3)
- Kernel version: 6.10.6
- Distribution: NixOS 24.11 (unstable)
ilya-zlobintsev commented 2 months ago

The file was created successfully - the message would show an error regarding it otherwise. It is however not applied until the initramfs is regenerated to include that file, which is not supported on nixos.

The message should probably be changed to not say that it is a success. However I'm not sure if including the kernel parameter by default in the package is a good idea - in some situations you might want to keep overclocking disabled while using other features of LACT. But if you do need it, you probably have to add the kernel parameter manually for now.

robertosw commented 2 months ago

I wouldn't want to always enable overclocking support either. However, it would be possible to create a sub-option for the lact options. Maybe something like lact.overclocking.enable which will then set the kernel parameter

robertosw commented 2 months ago

@ilya-zlobintsev would you be okay with that? I would look into adding this in the nixos options

ilya-zlobintsev commented 2 months ago

Sure, sounds good.