Dev/threaded plot render

ilya-zlobintsev / LACT

Linux GPU Configuration Tool

MIT License

1.46k stars 35 forks source link

Dev/threaded plot render #389

Closed In-line closed 1 month ago

In-line commented 1 month ago

Rendering of plots moved to individual low-priority threads, which are able to drop frames
- When resizing old texture is used when the new one isn't ready yet
- On the first open a momentary black screen can appear (but it's better than freezing the window)
- To further decrease CPU bottleneck cairo and plotters-cairo crates are compiled with opt-level 3
This notably prevents LACT GUI unresponsiveness in the Graphs subwindow
- On my system speedup for snapshot() function is 100x. From 4-5ms to 40-50us.
Plots look & feel further improved
- Throttling graph jumping around is fixed by doing more data preprocessing instead of margin
- Line thickness increased to 2
- Supersampling fixed to correctly adjust to any sizes
- Supersampling changed to 4x for better antialiasing
- Legend is using filled rectangles now
GUI benchmarks removed, sorry

better_plot

ilya-zlobintsev commented 1 month ago

The CI errors can be ignored, it's due to the fork not having a package signing secret.

In-line commented 1 month ago

Overall good changes, but I want to ask - was the plot rendering slow for you before? On my system the UI remains responsive even in a debug build, the only thing that is laggy is resizing the charts window. 4-5ms sounds a bit high for the snapshot period, on my system it's 2.7ms according to the old benchmark even before adding opt-level to plotters.

I think issue lies with my usage, as I like to fullscreen all the nice graphs we have.

And detaching it from GUI thread gives us room for higher supersampling. As currently this is 4x faster, because we render in parallel.

In-line commented 1 month ago

Oh I see, I think we need to increase scaling bounds for the Window or decrease text size. I use Polonun tiling in KDE, it seems it was always resizing the Window, that's why I didn't notice.

-------- Original Message -------- On 10/23/24 10:58, Ilya Zlobintsev wrote:

@ilya-zlobintsev requested changes on this pull request.

On my system the text is way too big (at least at the default window size). Do you happen to use a high DPI screen with scaling? Maybe that's why it's different on your screenshots.

image.png (view on web)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

In-line commented 1 month ago

Default size:

Fullscreen: Fullscreen 1440p