Closed ilyabelow closed 5 years ago
I suggest to use linters to validate code automatically
Besides, I'd recommend to rebase branch when you are ready with pull request to remove non-informative commits. For example, if you fixed a bug/added tests/functionality then many commits with informative titles are welcomed, but several uninformative commits supposed to fix CI should be fixed up into one commit/several informative commits.
Never install external packages into global scope through pip (or any other packaging system). This may cause inconsistency in dependencies and your system/some services may suddenly refuse to work. Use virtualenv instead.
Put a full installation instruction and name all the dependencies your project needs in readme. If a person doesn't have pygame, then they need to google what is it and how to install (and do it securely). That's a bad option.
Probably the best solution is to provide .sh script and .bat files. Keep in mind to allow script running without superuser rights (using virtualenv)
🔥
The last commits before I start writing docs and adding CI system and tests
UPD:
whoops, I accidentally integrated Travis Ci and started writing docstrings, oh well