search

ilyakatz / data-migrate

Migrate and update data alongside your database structure.
MIT License
1.4k stars 192 forks source link

Rails 7.2 update #312

Closed vprigent closed 1 month ago

vprigent commented 3 months ago

This brings support for Rails 7.2 connection configuration changes.

CI fails because Ruby 3.0 isn't compatible with Rails 7.2 activesupport-7.2.0.beta1 requires ruby version >= 3.1.0, which is incompatible I'd be keen to learn of a way around that if there is one?

Also noted, Ruby 3.0 is EOL'd, so a possible solution might be to drop it?

capripot commented 3 months ago

I agree, we should follow Rails' cadence and drop Ruby 3.0 too. Should we go to version 10 then?

vprigent commented 2 months ago

I agree, we should follow Rails' cadence and drop Ruby 3.0 too. Should we go to version 10 then?

Good point, I'll leave that decision to one of the contributors. perhaps @ngan would be able to review and cut a new version if they deem relevant?

Morozzzko commented 1 month ago

Rails 7.2 came out and now the lack of this fix is causing issues. Would be nice to get just about anything at this point

bruno-costanzo commented 1 month ago

Why is not possible to merge this?

ilyakatz commented 1 month ago

Hey folks, previous maintainers are no longer able to main the gem and I've been out of Rails ecosystem for many years now. So looking for someone willing to take over maintaining this gem .

In the meantime, @vprigent , thanks for taking this on. Since Ruby 3.0 is EOL, it can be removed from here https://github.com/ilyakatz/data-migrate/blob/4927b5612a1c0d9eb6ce12163ec5801ba85912d4/.github/workflows/build.yml#L14 and hopefully that will pass the build

after the build passes, I can deploy rc release for this change

Morozzzko commented 1 month ago

I'm somewhat invested into having up-to-date tools, so I can probably help with handling updates, deprecations and PRs which solve some of the obvious issues. Can't promise anything proactive in terms of evolution or making decision that'd affect the way this gem works, though.

bruno-costanzo commented 1 month ago

I can help also!

lorennav commented 1 month ago

I am available to help as well

ilyakatz commented 1 month ago

thanks folks, please send me an email @gmail and i can add you to maintainer group and slack channel for maintainers (not much action there, but easier to coordinate)

vprigent commented 1 month ago

Hi folks, good to see there's some attention and motivation to maintain the project.

I've updated the CI config to reflect the Ruby 3.0 deprecation. I believe this is ready to be merged.

ngan commented 1 month ago

Mind updating your branch?

capripot commented 1 month ago

✅ I've been using this branch successfully in Rails 7.2 beta2