search

ilyalatt / Telega

C# Telegram MTProto Client
https://ilyalatt.github.io/Telega/
MIT License
58 stars 15 forks source link

TelegramClientUpdates public field to Property. #47

Closed GihanSoft closed 3 years ago

GihanSoft commented 3 years ago

TelegramClientUpdates public field to Property.

GihanSoft commented 3 years ago

why this have previous commits? @ilyalatt

ilyalatt commented 3 years ago

you need to pull master and merge master into this branch

GihanSoft commented 3 years ago

@ilyalatt tanks.

ilyalatt commented 3 years ago

Can you make this change to all public readonly fields to reduce number of PR's?

GihanSoft commented 3 years ago

hmm. I'll try

GihanSoft commented 3 years ago

Code gen need fix? I think it's fixed but check it. I don't know much about code gen. need extra fix for in line initializer like this

public CustomObservable<UpdatesType> Updates { get; } = new CustomObservable<UpdatesType>();

you can apply it with this regex replace: search pattern:

public readonly (.+?);

replace pattern:

public $1 { get; }

2536 replace First time my CPU worked full power more than 1m in programming ant it wasn't a crash.

ilyalatt commented 3 years ago

Looks good. Fix Dispose brace and I'll merge it.

GihanSoft commented 3 years ago

where?

ilyalatt commented 3 years ago

i'll fix it myself