search

ilyasozkurt / mobilephone-brands-and-models

A database includes mobilephone manufacturers and their models.
GNU General Public License v3.0
78 stars 41 forks source link

Missing Information #5

Closed Ro-Den closed 2 years ago

Ro-Den commented 2 years ago

Some information is missing (JSON as example):

E.g.: Huawei Mate 40 Pro+

  1. Display Type ("OLED, HDR10, 90Hz"). Due to conflict with Battery Type.
  2. Memory unnamed ("SFS 1.0"). Due to conflict with Sound unnamed.
  3. Main Camera Features ("Leica optics, LED flash, panorama, HDR"). Due to conflict with Selfie Camera Features.
  4. Main Camera Video ("4K@30/60fps, 1080p@30/60/120/240/480fps, 720p@960fps, 720p@3840fps, HDR, gyro-EIS"). Due to conflict with Selfie Camera Video.

Also, it is wrong to use [Main Camera] "Penta" & [Selfie Camera] "Dual" as JSON keys. I think it's necessary to add two additional nested JSONs "main_camera" & "selfie_camera" with the following structure:

"main_camera": {"Main_Camera_Type":"Penta","Main_Camera_Specifications":"50 MP, f/1.9, 23mm (wide), 1/1.28", 1.22µm, omnidirectional PDAF, Laser AF, OIS 12 MP, f/2.4, (telephoto), PDAF, OIS, 3x optical zoom 8 MP, f/4.4, 240mm (periscope telephoto), PDAF, OIS, 10x optical zoom 20 MP, f/2.4, 14mm (ultrawide), PDAF TOF 3D, (depth)","Main_Camera_Features":"Leica optics, LED flash, panorama, HDR","Main_Camera_Video":"4K@30/60fps, 1080p@30/60/120/240/480fps, 720p@960fps, 720p@3840fps, HDR, gyro-EIS"},"selfie_camera": {"Selfie_Camera_Type":"Dual","Selfie_Camera_Specifications":"13 MP, f/2.4, 18mm (ultrawide) TOF 3D, (depth/biometrics sensor)","Selfie_Camera_Features":"HDR, panorama","Selfie_Camera_Video":"4K@30/60fps, 1080p@30/60/240fps"},

ilyasozkurt commented 2 years ago

Hello @Ro-Den,

Thank you for your feedback. If there is missing data, you can re-scrape data yourself by using the scraper script.

Have nice day!