search

ilyavolodin / eslint-plugin-backbone

Backbone specific linting rules for ESLint
MIT License
95 stars 11 forks source link

package.json lacks ESLint peerDependency #50

Closed platinumazure closed 9 years ago

platinumazure commented 9 years ago

The package.json of this project lacks a peerDependencies block with ESLint in it.

If you're not familiar with peerDependencies, the idea is that anyone trying to install this package as a dependency or dev dependency will get a warning if the peer dependencies are not also available elsewhere in the consuming project's dependency tree. Since this is an extension of ESLint and ESLint manages plugin hooks, it would be incorrect for this project to specify ESLint as a dependency; however, we should take advantage of NPM's functionality to warn if ESLint isn't present in the project dependency tree, since we do piggyback off of whatever ESLint is installed.

If my no-view-qualified-jquery pull request lands, we will need to set the ESLint peer dependency version to ^1.3.0. If any of the rules use autofix, the peer dependency version will need to be ^1.4.0. (And so on for any other recent ESLint features we're using.)

If this is accepted and I don't get direction to specify a different version, I'll create a pull request specifying ^1.3.0.

ilyavolodin commented 9 years ago

Hmm... I thought I always had it. Very strange.

platinumazure commented 9 years ago

Maybe I missed it? I can take another look later. If you happen to beat me to it and find I'm wrong, feel free to close this. On Oct 26, 2015 7:49 AM, "Ilya Volodin" notifications@github.com wrote:

Hmm... I thought I always had it. Very strange.

— Reply to this email directly or view it on GitHub https://github.com/ilyavolodin/eslint-plugin-backbone/issues/50#issuecomment-151122947 .