search

ilyavolodin / eslint-plugin-backbone

Backbone specific linting rules for ESLint
MIT License
95 stars 11 forks source link

Support for ESlint 2.x #57

Closed darrenhaken closed 8 years ago

darrenhaken commented 8 years ago

When I tried to use the plugin NPM complained of an unmet dependency.

darrenhaken commented 8 years ago

Any reason we couldn't upgrade o the new ESLint version and publish?

platinumazure commented 8 years ago

I think the package.json should specify "eslint": ">=1.10.0" instead of "eslint": "^1.10.0", unless we think the plugin has consumed new, breaking functionality from ESLint that will leave our 1.x users in the dust.

platinumazure commented 8 years ago

@darrenhaken Just so we have a record, could you please post the exact output of what you get when you try to install? And if you could list your ESLint version as well, that would be helpful.

ilyavolodin commented 8 years ago

I was planning on bumping up version of ESLint in package.json, but it completely slipped my mind. I'll try to do that sometime this week and do a release of new version.

darrenhaken commented 8 years ago

That's great. If you want me to do it and send a PR let me know and I can do that

ilyavolodin commented 8 years ago

Thanks for the offer. I wanted to do some additional changes that are not documented yet. This should now be fixed.

darrenhaken commented 8 years ago

Thanks for fixing this off @ilyavolodin