Fix crash when applying "on-top" rules to ES6 modules

ilyavolodin / eslint-plugin-backbone

Backbone specific linting rules for ESLint

MIT License

95 stars 11 forks source link

Fix crash when applying "on-top" rules to ES6 modules #70

Closed brianhelba closed 7 years ago

brianhelba commented 7 years ago

Add tests for applying on-top rules to ES6 modules
Fix crash when applying on-top rules to ES6 modules
- The greatgrandparent of an ES6 module "export" statement is null. Avoid further inspection of these nodes in "checkIfPropertyInBackboneModel" by first checking whether they are part of an "ObjectExpression" at all.

Fixes #66

brianhelba commented 7 years ago

@ilyavolodin Please take a look.

I realize that the test code I added goes a little outside the scope of the existing tests, as it validates totally non-Backbone syntax. If you'd like to keep the tests "pure", I can remove that commit. I just wanted to demonstrate the error and the working fix for the purposes of this PR.

brianhelba commented 7 years ago

@ilyavolodin Updated.

ilyavolodin commented 7 years ago

LGTM, thanks.