I really like the reverse engineering effort and the effort to make the results available to an open source community. Thank you for that!
What I do not like are the dependencies of this project, which makes the package very difficult to use. It uses the (to my mind) unnecessary pygattlib library. Pygattlib is not a wrapper around gatttlib (a tool from the bluez package) but more a fork of it, since it ships and compiles its own (outdated!) version.
To ease the installation I would recommend to make this a pure python package (including dependencies) by just calling gatttlib in a subprocess. This would also make testing much simpler. Check e.g. this library that does the same with a different Ble thermostat device.
I really like the reverse engineering effort and the effort to make the results available to an open source community. Thank you for that!
What I do not like are the dependencies of this project, which makes the package very difficult to use. It uses the (to my mind) unnecessary pygattlib library. Pygattlib is not a wrapper around gatttlib (a tool from the bluez package) but more a fork of it, since it ships and compiles its own (outdated!) version.
To ease the installation I would recommend to make this a pure python package (including dependencies) by just calling gatttlib in a subprocess. This would also make testing much simpler. Check e.g. this library that does the same with a different Ble thermostat device.