im-0 / cometblue

Command line tool and python library for "Comet Blue" thermostat
GNU General Public License v3.0
34 stars 24 forks source link

Accept Pull Request #8

Open zapedge opened 6 years ago

zapedge commented 6 years ago

Hey,

it would be nice if you could accept the Pull request https://github.com/im-0/cometblue/pull/6

I want to use your tool to implement cometblue into the homeassitant home automation hub, but it needs to be python3 and available via pip. @xrucka did a great job so far porting your tool to python3. please consider to accept his changes.

greetings

RobsyRocket commented 6 years ago

I would also appreciate a merge, because I was also not able to make the current version work. One or multiple dependencies/libraries could not be resolved.

mirko commented 6 years ago

@zapedge I'm also about to integrate this into home-assistant. While this project seems unmaintained I started upon the fork from xrucka https://github.com/xrucka/cometblue . Maybe we can merge efforts?

xrucka commented 6 years ago

@RobsyRocket Hi, I get ambiguous reference for "current version" - do you mean mine, or im-0's?

@mirko @zapedge - I'm currently getting familiar with OpenHab internals and slowly moving towards getting support for this regulator in https://github.com/sputnikdev/eclipse-smarthome-bluetooth-binding/ , yet I have too little time to do it :-/. (fyi)

mirko commented 6 years ago

I'm pretty confident I'll have a first version to test for home-assistant this week.

mirko commented 6 years ago

Here we go: https://github.com/mirko/home-assistant/blob/cometblue/homeassistant/components/climate/cometblue.py