search

im-archive / eslint-config-exchange-solutions

ESLint Default configurations for Towers Watson Exchange Solutions
MIT License
0 stars 3 forks source link

Re: props.children and props.className #13

Open stevematney opened 8 years ago

stevematney commented 8 years ago

These properties have implied definitions in pretty much all React components. Should we really be requiring that they're defined in the propTypes definitions? That seems excessive.

aabenoja commented 8 years ago

I would agree with this. While I like the rationale that the props being used in the component should be somewhat explicit, children and className are fairly implicit in how they are used. Most cases there will not be variants in how they are used, so constantly going children: PropTypes.node and className: PropTypes.string is fairly asinine. If it were the case that their usage is out of the norm I will not be against requiring the validation.

mtscout6 commented 8 years ago

I'm fine with that. We take Pull Requests :)