im-ethz / flirt

Are you ready to FLIRT with your wearable data?
https://flirt.readthedocs.io
Other
61 stars 21 forks source link

Terminology for "lineintegral" feature #10

Open evavanweenen opened 1 year ago

evavanweenen commented 1 year ago

Heyhey,

This issue was initiated by a discussion in which Felix was confused by usage of the phrase "lineintegral" instead of just an integral. As we understood it, line integral is usually over multi-dimensional field/vector/line or along a curve. In the flirt package, I think the integral is only calculated for 1D lines right? (HRV, EDA, ACC-x, ACC-y, ACC-z, ACC-l2, etc.), so we think it should be called integral instead of line integral. Let me know if this is not the case, then I don't have to update my figures ;)

Cheers, Eva

evavanweenen commented 1 year ago

Also happy to change these tiny things myself in the package, but don't want the code to break elsewhere/touch your project and accidentally break it ;)