im-richard / Scaffold

Extend, combine and compress CSS
http://github.com/IAMRichardT/Scaffold/wiki
161 stars 19 forks source link

304 response even on forced cache refresh #21

Open mfernea opened 14 years ago

mfernea commented 14 years ago

When forcing a cache refresh (ctrl+f5) scaffold still returns a 304 not modified response. It seems to me that the problem appers because modified method in Scaffold_Response_Cache class doesn't check if the _modified_since has a proper value. Thus the comparison returns false even if _modified_since is set to 0.

Other problem is that _modified_since is an integer and $last_modified is a string.

Anyway, I'm very glad to see that the work on this project is continuing. Best regards!

anthonyshort commented 14 years ago

Thanks, I'll take a look at this and get back to you!