search

im-tomu / valentyusb

FPGA USB stack written in LiteX
BSD 3-Clause "New" or "Revised" License
125 stars 25 forks source link

setup.py #4

Closed lromor closed 4 years ago

lromor commented 4 years ago

Are you interested in packaging this project? Is the endgoal to include it in litex? I would like to add a setup.py in order to include it as requirements.txt dependency in my project.

xobs commented 4 years ago

I'm not against packaging this project, I just don't particularly understand how it's supposed to work, or what one is supposed to do. And I gather the defaults are wrong, or that it's very easy to do the wrong thing. I've broken my system many times accidentally.

However, if a setup.py were to be provided as part of a PR, I would merge it.

lromor commented 4 years ago

Yes, I understand your point, the reason why I'm using it is to pack the dependencies for a litex fomu project. Instead of using lxbuildenv, I'm using a requirements.txt. This is the "project template" (there's nothing in there yet =P)

https://github.com/lromor/fomu-decelerator

as you can see here https://github.com/lromor/fomu-decelerator/blob/master/requirements.txt#L5 In this way if you run pip install -r requirements.txt it automatically fetches the repo and adds it to your virtual environment or system/user wide. Without the setup.py pip doesn't know how to install the package and returns an error. This is a very quick and dirty setup.py :)

This is useful since locally, I would like to prepare pull requests for all the repos involved and in this way I can either link my project to the local version of say litex vs the github one.

rjeschmi commented 4 years ago

I also would find it useful for dev work. The rest of litex installs this way. I added a simple one manually and it works fine for my use, but it would be helpful to get it upstream.

xobs commented 4 years ago

I also would find it useful for dev work. The rest of litex installs this way. I added a simple one manually and it works fine for my use, but it would be helpful to get it upstream.

Could you please submit a PR with your setup.py file?

rjeschmi commented 4 years ago

I see my PR was merged. I noticed the test failures, but they seemed to be upstream. Let me know if you prefer some mods. This can be closed if not.

https://github.com/im-tomu/valentyusb/pull/5

xobs commented 4 years ago

The test failures appear to be due to bitrot in the test framework. I've opened an issue in that repository.

I have a local patch that updates the author fields, which I'll push shortly. Aside from that, let me know if there's anything else you think this file needs.