search

im85288 / service.upnext

GNU General Public License v2.0
81 stars 42 forks source link

UpNext and non-library content #278

Open 93Sprinter opened 2 years ago

93Sprinter commented 2 years ago

Hi, I recently found out about this addon and wanted to try some things. I read a few comments about support for non-library content in playlists and wanted to try that out with my Orbsmart TV Box that runs with Coreelec.

I installed UpNext and plugged in my external HDD. I selected some episodes with the context menu entry "Play from here" and skipped to the end of the video to check if the UpNext dialog is displayed. Unfortunately that did not work. To confirm that UpNext generally works on my machine I added the series to my library and played it again. After that the UpNext dialog showed up normally.

So I deleted the series from my library again and looked a little bit into the code here on GitHub.

I found a if-clause in the player.py file in the method "_check_video" which prevents tracking of videos in the UpNextMointor if they are not of type episodes. For test purposes I delete that clause and installed my own version of UpNext and tried again. This time the UpNext dialog also showed up after I just selected some videos from my HDD that were not in my library.

So I have two questions: 1.) Did I do something wrong while playing the non-library content while I did not get the dialog? 2.) Is this if-clause in player.py necessary? Maybe this could be removed or the if clause could be extended for files and movies and not just episodes. (Maybe this could be a Setting?)

Thanks

MoojMidge commented 2 years ago

The fixes to allow non-library content to work with UpNext started with #247, but also required #251 (for addons) and #260 (for playlists).

Answers to your questions: 1) No, UpNext wasn't able to handle such content previously, and I never got around to creating a PR to remove the restriction now that it could. 2) No, it should no longer be necessary. If you have made the change yourself then it should largely work without problems, but you may run into some issues with strm files.