im85288 / service.upnext

GNU General Public License v2.0
80 stars 41 forks source link

Request: Skip intro functionality at the beginning of an episode. #289

Closed no-bdy closed 1 year ago

no-bdy commented 1 year ago

Add functionality to show a skip intro button at the beginning of episodes.

Noted in post https://forum.kodi.tv/showthread.php?tid=356919&pid=3122503#pid3122503

Up Next version: 1.1.8+matrix.1, File: monitor.py

Line 103 -if total_time - play_time > notification_time: +if total_time - play_time > notification_time and play_time > 120: # do not continue under 120 seconds, should be user defined same as time from end to display up next dialog

Add code after line 105

+if play_time < 120:

Obviously we don't want static values here, just an example, use settings to determine less than play_time value for skip intro and amount of time to skip. Should be routed to something similar to self.playback_manager.launch_up_next() with a new XML GUI showing a skip instead of a Play Next

Looks to be relatively simple to do this. Obvious concerns:

It may not skip only intros because the timing isn't setup right, no worse than timing at the end though. When seeking kodi will pick the nearest video keyframe rather than an exact timestamp. Recommend seek forward by offset seconds instead of seekTime.

no-bdy commented 1 year ago

I should read more before opening new issues. I found in milestones where this was discussed and discarded in Feb 2020.