im85288 / service.upnext

GNU General Public License v2.0
81 stars 42 forks source link

Clicking Play Next or Close does nothing #86

Closed stathis95194 closed 4 years ago

stathis95194 commented 4 years ago

I cannot manage to make this work. All settings to Up Next and Seren or Venom are enabled and identical. Popup comes up as expected on the time expected, but even if click Play Next, nothing happens. Stream finishes and continues to the next one only when time runs out.

Log isn't very helpful as it shows that everything is fine even though it isn't. Am i missing something?

A thing i noticed is that at the beginning of each episode, Up Next shows the popup for a completely unrelated show (Game of Thrones s2e4) which i need to "Close" 3 times to disappear. I found nothing on log regarding this though

2019-11-17 19:50:08.468 T:14427 NOTICE: Opening stream: 0 source: 1024 2019-11-17 19:50:41.590 T:12617 NOTICE: UP NEXT Monitor -> log : Calling autoplayback totaltime - playtime is 49.5129394531 2019-11-17 19:50:41.603 T:12617 NOTICE: UP NEXT Api -> log : handle_addon_lookup_of_next_episode episode returning data {"rating": 8.0, "tvshowid": "tt4524056", "art": {"tvshow.fanart": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "thumb": "https://www.thetvdb.com/banners/episodes/294741/5202823.jpg", "tvshow.clearart": "", "tvshow.landscape": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "tvshow.poster": "https://www.thetvdb.com/banners/posters/294741-15.jpg", "tvshow.clearlogo": ""}, "plot": "Macarena's confrontation with self-appointed prison queen bee Zulema endangers her family.", "season": 1, "title": "Episode 3", "episodeid": 1848870, "firstaired": "2015-05-04", "episode": 3, "playcount": 0, "showtitle": "Vis a Vis"} 2019-11-17 19:50:41.614 T:12617 NOTICE: UP NEXT Api -> log : handle_addon_lookup_of_current episode returning data {"rating": 0.0, "tvshowid": "tt4524056", "art": {"tvshow.fanart": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "thumb": "https://www.thetvdb.com/banners/episodes/294741/5202822.jpg", "tvshow.clearart": "", "tvshow.landscape": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "tvshow.poster": "https://www.thetvdb.com/banners/posters/294741-15.jpg", "tvshow.clearlogo": ""}, "plot": "Macarena is caught with a package of drugs and is tricked into revealing who owned them.", "season": 1, "title": "Episode 2", "episodeid": 1848869, "firstaired": "2015-04-27", "episode": 2, "playcount": 1, "showtitle": "Vis a Vis"} 2019-11-17 19:50:41.624 T:12617 NOTICE: UP NEXT PlaybackManager -> log : episode details {"rating": 8.0, "tvshowid": "tt4524056", "art": {"tvshow.fanart": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "thumb": "https://www.thetvdb.com/banners/episodes/294741/5202823.jpg", "tvshow.clearart": "", "tvshow.landscape": "https://www.thetvdb.com/banners/fanart/original/294741-8.jpg", "tvshow.poster": "https://www.thetvdb.com/banners/posters/294741-15.jpg", "tvshow.clearlogo": ""}, "plot": "Macarena's confrontation with self-appointed prison queen bee Zulema endangers her family.", "season": 1, "title": "Episode 3", "episodeid": 1848870, "firstaired": "2015-05-04", "episode": 3, "playcount": 0, "showtitle": "Vis a Vis"} 2019-11-17 19:50:41.650 T:12617 NOTICE: UP NEXT PlaybackManager -> log : played in a row settings "3" 2019-11-17 19:50:41.660 T:12617 NOTICE: UP NEXT PlaybackManager -> log : played in a row 1 2019-11-17 19:50:41.669 T:12617 NOTICE: UP NEXT PlaybackManager -> log : showing next up page as played in a row is 1 2019-11-17 19:50:48.903 T:12617 NOTICE: UP NEXT PlaybackManager -> log : playing media episode 2019-11-17 19:50:48.913 T:12617 NOTICE: UP NEXT Api -> log : sending data to addon to play: {"item_id": 1848869} 2019-11-17 19:50:48.921 T:12617 NOTICE: UP NEXT Monitor -> log : Up Next style autoplay succeeded.

dagwieers commented 4 years ago

What version of Up Next are you running? I would advise to run the master branch as we have fixed a few important issues recently.

stathis95194 commented 4 years ago

I'm on 1.0.1 from Kodi addons

dagwieers commented 4 years ago

@stathis95194 Could you try the master branch? We would like to release a new version to the Kodi repositories sooner rather than later.

You can download the ZIP file from GitHub (via the Clone or download button on the main page) and install that in Kodi (Install from ZIP).

stathis95194 commented 4 years ago

Tried the master branch...1.0.3 is a no go again. This time i don't even get the popup window.

And again log shows everything fine

2019-11-17 22:47:16.949 T:26300 WARNING: Previous line repeats 1 times. 2019-11-17 22:47:16.949 T:26300 NOTICE: [service.upnext] Monitor -> Calling autoplayback totaltime - playtime is 49.7758789062 2019-11-17 22:47:16.990 T:26300 NOTICE: [service.upnext] Api -> Got details of next playlist item {u'jsonrpc': u'2.0', u'id': 1, u'result': {u'items': [{u'plot': u'Jack is granted permission from Senator Chapin to stay in Venezuela. President Reyes denies involvement in the events that are keeping Jack in the country.\r\nJack and Harry team up to follow a lead that could create dissension within the ranks.', u'tvshowid': -1, u'dateadded': u'', u'episode': 2, u'rating': 0.0, u'season': 2, u'lastplayed': u'', u'resume': {u'position': 0.0, u'total': 0.0}, u'label': u'Tertia Optio', u'writer': [], u'firstaired': u'2019-10-31', u'title': u'Tertia Optio', u'file': u'plugin://plugin.video.seren/?action=getSources&actionArgs=%7B%22episode%22%3A%202%2C%20%22item_type%22%3A%20%22episode%22%2C%20%22season%22%3A%202%2C%20%22trakt_id%22%3A%20124381%7D', u'art': {u'thumb': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fepisodes%2f336261%2f7347095.jpg/', u'fanart': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5d3deb5cc706a.jpg/', u'poster': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fposters%2f5d717c4928d53.jpg/', u'fanart3': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5b89930090e34.jpg/', u'fanart4': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f336261-1.jpg/', u'fanart1': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5d717b7ce5ec9.jpg/', u'landscape': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fepisodes%2f336261%2f7347095.jpg/', u'fanart2': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5b314ddcf1328.jpg/'}, u'playcount': 1, u'runtime': 3600, u'type': u'episode', u'showtitle': u"Tom Clancy's Jack Ryan", u'streamdetails': {u'video': [], u'audio': [], u'subtitle': []}}], u'limits': {u'start': 1, u'total': 8, u'end': 2}}} 2019-11-17 22:47:16.993 T:26300 NOTICE: [service.upnext] PlaybackManager -> episode details {u'plot': u'Jack is granted permission from Senator Chapin to stay in Venezuela. President Reyes denies involvement in the events that are keeping Jack in the country.\r\nJack and Harry team up to follow a lead that could create dissension within the ranks.', u'tvshowid': -1, u'dateadded': u'', u'episode': 2, u'rating': 0.0, u'season': 2, u'lastplayed': u'', u'episodeid': None, u'resume': {u'position': 0.0, u'total': 0.0}, u'label': u'Tertia Optio', u'writer': [], u'firstaired': u'2019-10-31', u'title': u'Tertia Optio', u'file': u'plugin://plugin.video.seren/?action=getSources&actionArgs=%7B%22episode%22%3A%202%2C%20%22item_type%22%3A%20%22episode%22%2C%20%22season%22%3A%202%2C%20%22trakt_id%22%3A%20124381%7D', u'art': {u'thumb': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fepisodes%2f336261%2f7347095.jpg/', u'fanart': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5d3deb5cc706a.jpg/', u'poster': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fposters%2f5d717c4928d53.jpg/', u'fanart3': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5b89930090e34.jpg/', u'fanart4': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f336261-1.jpg/', u'fanart1': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5d717b7ce5ec9.jpg/', u'landscape': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2fepisodes%2f336261%2f7347095.jpg/', u'fanart2': u'image://https%3a%2f%2fwww.thetvdb.com%2fbanners%2ffanart%2foriginal%2f5b314ddcf1328.jpg/'}, u'playcount': 1, u'runtime': 3600, u'type': u'episode', u'showtitle': u"Tom Clancy's Jack Ryan", u'streamdetails': {u'video': [], u'audio': [], u'subtitle': []}} 2019-11-17 22:47:16.995 T:26300 NOTICE: [service.upnext] Monitor -> Up Next style autoplay succeeded. 2019-11-17 22:47:55.763 T:28084 NOTICE: CVideoPlayerAudio::Process - stream stalled 2019-11-17 22:47:55.789 T:28071 NOTICE: CVideoPlayer::OnExit() 2019-11-17 22:47:55.789 T:28071 NOTICE: VideoPlayer: eof, waiting for queues to empty 2019-11-17 22:47:55.789 T:28071 NOTICE: Closing stream player 1 2019-11-17 22:47:55.789 T:28071 NOTICE: CDVDMessageQueue(audio)::WaitUntilEmpty 2019-11-17 22:47:55.790 T:28071 NOTICE: Waiting for audio thread to exit 2019-11-17 22:47:55.790 T:28084 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true 2019-11-17 22:47:55.790 T:28084 NOTICE: thread end: CVideoPlayerAudio::OnExit() 2019-11-17 22:47:55.790 T:28071 NOTICE: Closing audio device 2019-11-17 22:47:55.819 T:28071 NOTICE: Deleting audio codec 2019-11-17 22:47:55.820 T:28071 NOTICE: Closing stream player 2 2019-11-17 22:47:55.820 T:28071 NOTICE: CDVDMessageQueue(video)::WaitUntilEmpty 2019-11-17 22:47:56.015 T:28071 NOTICE: waiting for video thread to exit 2019-11-17 22:47:56.015 T:28082 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true 2019-11-17 22:47:56.015 T:28082 NOTICE: thread end: video_thread 2019-11-17 22:47:56.016 T:28071 NOTICE: deleting video codec 2019-11-17 22:47:56.083 T:28071 NOTICE: Closing stream player 3 2019-11-17 22:47:56.393 T:26274 NOTICE: Trying to open: samplerate: 44100, channelMask: 12, encoding: 4 2019-11-17 22:47:56.398 T:26274 NOTICE: CAESinkAUDIOTRACK::Initializing with: m_sampleRate: 44100 format: AE_FMT_FLOAT (AE) method: PCM stream-type: PCM-STREAM min_buffer_size: 60320 m_frames: 3770 m_frameSize: 8 channels: 2

dagwieers commented 4 years ago

I cannot reproduce this with the add-ons I am using. Maybe it makes more sense to report this to the upstream projects of these add-ons so they can troubleshoot, and if needed, report the issue or offer a PR here?

dagwieers commented 4 years ago

I would suggest to restart Kodi to ensure there's no left-over processes conflicting with one another. And maybe update to v1.0.6 before doing this.

stathis95194 commented 4 years ago

I would suggest to restart Kodi to ensure there's no left-over processes conflicting with one another. And maybe update to v1.0.6 before doing this.

Updated to 1.0.6. Closed kodi and reopened. Also cleared cache of Venom to be on the safe side.

Set UpNext to debug mode and run a show. Here is the log from start to end. UpNext throws some errors, so hopefully it will help pinpoint the issue. BTW UpNext icon flashed 3 times on the beginning of the episodes without giving me time to click anything, and never appeared on the end of the episode

2019-11-26 18:25:04.936 T:26366 NOTICE: ResolveURL: Initializing ResolveURL version: 5.0.36 2019-11-26 18:25:39.538 T:16227 NOTICE: VideoPlayer::OpenFile: https://40.download.real-debrid.com/d/Q3PI3N55UPVXA/Just.Roll.With.It.S01E03.720p.HEVC.x265-MeGusta.mkv 2019-11-26 18:25:39.903 T:27259 NOTICE: Creating InputStream 2019-11-26 18:25:40.858 T:27259 NOTICE: Creating Demuxer 2019-11-26 18:25:40.936 T:27259 NOTICE: Opening stream: 0 source: 256 2019-11-26 18:25:40.937 T:27259 NOTICE: Whitelist search for: width: 1280, height: 720, fps: 23.976, 3D: false 2019-11-26 18:25:40.937 T:27259 NOTICE: Display resolution ADJUST : 1920x1080 @ 60.000004 - Full Screen (16) (weight: -2863.562) 2019-11-26 18:25:40.952 T:27259 NOTICE: Creating video codec with codec id: 173 2019-11-26 18:25:40.956 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.audio.decoder.ac3 2019-11-26 18:25:40.956 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.audio.decoder.dtshd 2019-11-26 18:25:40.956 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.audio.decoder.eac3 2019-11-26 18:25:40.956 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.audio.decoder.ffmpeg 2019-11-26 18:25:40.957 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.vp6a.decoder.sw 2019-11-26 18:25:40.957 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.vp6f.decoder.sw 2019-11-26 18:25:40.957 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.avc.decoder.awesome 2019-11-26 18:25:40.957 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.avs.decoder.awesome 2019-11-26 18:25:40.958 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.h263.decoder.awesome 2019-11-26 18:25:40.958 T:27259 NOTICE: CDVDVideoCodecAndroidMediaCodec::Open Testing codec:OMX.amlogic.hevc.decoder.awesome 2019-11-26 18:25:41.177 T:27259 NOTICE: Creating video thread 2019-11-26 18:25:41.178 T:27294 NOTICE: running thread: video_thread 2019-11-26 18:25:41.257 T:27259 NOTICE: Opening stream: 1 source: 256 2019-11-26 18:25:41.257 T:27259 NOTICE: Finding audio codec for: 86018 2019-11-26 18:25:41.259 T:27259 NOTICE: CDVDAudioCodecFFmpeg::Open() Successful opened audio decoder aac 2019-11-26 18:25:41.260 T:27259 NOTICE: Creating audio thread 2019-11-26 18:25:41.262 T:27306 NOTICE: running thread: CVideoPlayerAudio::Process() 2019-11-26 18:25:41.279 T:27306 NOTICE: Creating audio stream (codec id: 86018, channels: 2, sample rate: 48000, no pass-through) 2019-11-26 18:25:41.284 T:16247 NOTICE: Trying to open: samplerate: 48000, channelMask: 12, encoding: 4 2019-11-26 18:25:41.306 T:16247 NOTICE: CAESinkAUDIOTRACK::Initializing with: m_sampleRate: 48000 format: AE_FMT_FLOAT (AE) method: PCM stream-type: PCM-STREAM min_buffer_size: 65600 m_frames: 4100 m_frameSize: 8 channels: 2 2019-11-26 18:25:41.759 T:16227 NOTICE: Instancing CRendererMediaCodecSurface 2019-11-26 18:25:41.759 T:16227 NOTICE: CRendererMediaCodecSurface::Configure 2019-11-26 18:25:41.801 T:16227 NOTICE: Whitelist search for: width: 1280, height: 720, fps: 23.976, 3D: false 2019-11-26 18:25:41.802 T:16227 NOTICE: Display resolution ADJUST : 1920x1080 @ 60.000004 - Full Screen (16) (weight: -2863.562) 2019-11-26 18:25:44.674 T:26366 ERROR: Traceback (most recent call last): 2019-11-26 18:25:44.674 T:26366 ERROR: File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.venom/resources/lib/modules/player.py", line 625, in get 2019-11-26 18:25:44.675 T:27315 NOTICE: service.subtitles.rvm.addic7ed: Searching for subs... 2019-11-26 18:25:44.677 T:26366 ERROR: lang = filter[0]['SubLanguageID'] 2019-11-26 18:25:44.677 T:26366 ERROR: IndexError: list index out of range 2019-11-26 18:25:44.681 T:26366 NOTICE: onAVStarted callback 2019-11-26 18:25:44.992 T:26366 ERROR: Traceback (most recent call last): 2019-11-26 18:25:44.992 T:26366 ERROR: File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.venom/resources/lib/modules/player.py", line 625, in get 2019-11-26 18:25:44.992 T:26366 ERROR: lang = filter[0]['SubLanguageID'] 2019-11-26 18:25:44.992 T:26366 ERROR: IndexError: list index out of range 2019-11-26 18:25:44.993 T:26366 NOTICE: onPlayBackStarted callback 2019-11-26 18:25:45.464 T:27315 NOTICE: service.subtitles.rvm.addic7ed: No subs for "just roll with it 01x03" found. 2019-11-26 18:25:45.914 T:16287 ERROR: EXCEPTION: Non-Existent Control 3014 2019-11-26 18:25:45.933 T:16287 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

  • NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.RuntimeError'> Error Contents: Non-Existent Control 3014 Traceback (most recent call last): File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/player.py", line 42, in onPlayBackStarted self.developer.developer_play_back() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/developer.py", line 37, in developer_play_back next_up_page_simple.update_progress_control() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/upnext.py", line 78, in update_progress_control self.progress_control = self.getControl(3014) RuntimeError: Non-Existent Control 3014 -->End of Python script error report<-- 2019-11-26 18:25:46.099 T:16287 ERROR: EXCEPTION: Non-Existent Control 3014 2019-11-26 18:25:46.115 T:16287 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
  • NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.RuntimeError'> Error Contents: Non-Existent Control 3014 Traceback (most recent call last): File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/player.py", line 42, in onPlayBackStarted self.developer.developer_play_back() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/developer.py", line 37, in developer_play_back next_up_page_simple.update_progress_control() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/upnext.py", line 78, in update_progress_control self.progress_control = self.getControl(3014) RuntimeError: Non-Existent Control 3014 -->End of Python script error report<-- 2019-11-26 18:25:46.285 T:16287 ERROR: EXCEPTION: Non-Existent Control 3014 2019-11-26 18:25:46.299 T:16287 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
  • NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.RuntimeError'> Error Contents: Non-Existent Control 3014 Traceback (most recent call last): File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/player.py", line 42, in onPlayBackStarted self.developer.developer_play_back() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/developer.py", line 37, in developer_play_back next_up_page_simple.update_progress_control() File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.upnext/resources/lib/upnext.py", line 78, in update_progress_control self.progress_control = self.getControl(3014) RuntimeError: Non-Existent Control 3014 -->End of Python script error report<-- 2019-11-26 18:25:51.208 T:26366 WARNING: CAddonSettings[script.module.metahandler]: failed to parse old setting definition for "db_port" of type "integer" 2019-11-26 18:25:51.216 T:26366 NOTICE: metahandler: Initializing MetaHandlers version: 3.99.02 2019-11-26 18:25:51.259 T:26366 WARNING: CAddonSettings[script.module.metahandler]: failed to parse old setting definition for "db_port" of type "integer" 2019-11-26 18:25:51.262 T:26366 ERROR: metahandler: Metahandlers does NOT come with API keys, developer must supply their own 2019-11-26 18:25:51.264 T:26366 NOTICE: metahandler: Loading sqlite3 as DB engine version: 3.26.0 2019-11-26 18:25:51.682 T:26366 ERROR: metahandler: Error connecting to TMDB: HTTP Error 401: Unauthorized 2019-11-26 18:27:05.806 T:16287 NOTICE: [service.upnext] Monitor -> Calling autoplayback totaltime - playtime is 41.6710205078 2019-11-26 18:27:05.808 T:16287 NOTICE: [service.upnext] Api -> Got active player {u'jsonrpc': u'2.0', u'id': 1, u'result': [{u'playerid': 1, u'type': u'video', u'playertype': u'internal'}]} 2019-11-26 18:27:05.809 T:16287 NOTICE: [service.upnext] Api -> Getting details of now playing media 2019-11-26 18:27:05.844 T:16287 NOTICE: [service.upnext] Api -> Got details of now playing media {u'jsonrpc': u'2.0', u'id': 1, u'result': {u'item': {u'plotoutline': u'', u'episode': 3, u'season': 1, u'tvshowid': -1, u'label': u'Blair Gets Grounded', u'genre': [u'Comedy', u'Family'], u'playcount': 0, u'type': u'episode', u'showtitle': u'Just Roll With It'}}} 2019-11-26 18:27:05.859 T:16287 NOTICE: [service.upnext] PlayItem -> Fetched missing tvshowid -1 2019-11-26 18:27:05.861 T:16287 NOTICE: [service.upnext] PlaybackManager -> Error: no episode could be found to play next...exiting 2019-11-26 18:27:05.864 T:16287 NOTICE: [service.upnext] Monitor -> Up Next style autoplay succeeded. 2019-11-26 18:27:12.687 T:26366 ERROR: metahandler: Metahandlers does NOT come with API keys, developer must supply their own 2019-11-26 18:27:12.687 T:26366 NOTICE: metahandler: Loading sqlite3 as DB engine version: 3.26.0 2019-11-26 18:27:13.076 T:26366 ERROR: metahandler: Error connecting to TMDB: HTTP Error 401: Unauthorized 2019-11-26 18:27:46.976 T:27259 NOTICE: CVideoPlayer::OnExit() 2019-11-26 18:27:46.976 T:27259 NOTICE: VideoPlayer: eof, waiting for queues to empty 2019-11-26 18:27:46.976 T:27259 NOTICE: Closing stream player 1 2019-11-26 18:27:46.976 T:27259 NOTICE: CDVDMessageQueue(audio)::WaitUntilEmpty 2019-11-26 18:27:46.977 T:27306 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true 2019-11-26 18:27:46.977 T:27306 NOTICE: thread end: CVideoPlayerAudio::OnExit() 2019-11-26 18:27:46.977 T:27259 NOTICE: Waiting for audio thread to exit 2019-11-26 18:27:46.977 T:27259 NOTICE: Closing audio device 2019-11-26 18:27:47.063 T:27259 NOTICE: Deleting audio codec 2019-11-26 18:27:47.063 T:27259 NOTICE: Closing stream player 2 2019-11-26 18:27:47.063 T:27259 NOTICE: CDVDMessageQueue(video)::WaitUntilEmpty 2019-11-26 18:27:47.220 T:27259 NOTICE: waiting for video thread to exit 2019-11-26 18:27:47.220 T:27294 ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true 2019-11-26 18:27:47.220 T:27294 NOTICE: thread end: video_thread 2019-11-26 18:27:47.220 T:27259 NOTICE: deleting video codec 2019-11-26 18:27:47.490 T:16227 NOTICE: CVideoPlayer::CloseFile() 2019-11-26 18:27:47.490 T:16227 NOTICE: VideoPlayer: waiting for threads to exit 2019-11-26 18:27:47.490 T:16227 NOTICE: VideoPlayer: finished waiting 2019-11-26 18:27:47.490 T:16227 NOTICE: CVideoPlayer::CloseFile() 2019-11-26 18:27:47.490 T:16227 NOTICE: VideoPlayer: waiting for threads to exit 2019-11-26 18:27:47.490 T:16227 NOTICE: VideoPlayer: finished waiting 2019-11-26 18:27:47.507 T:16227 ERROR: Control 55 in window 10025 has been asked to focus, but it can't 2019-11-26 18:27:47.540 T:26366 NOTICE: onPlayBackEnded callback 2019-11-26 18:27:47.682 T:16247 NOTICE: Trying to open: samplerate: 44100, channelMask: 12, encoding: 4 2019-11-26 18:27:47.687 T:16247 NOTICE: CAESinkAUDIOTRACK::Initializing with: m_sampleRate: 44100 format: AE_FMT_FLOAT (AE) method: PCM stream-type: PCM-STREAM min_buffer_size: 60320 m_frames: 3770 m_frameSize: 8 channels: 2
dagwieers commented 4 years ago

We have released a new version v1.0.7 in the Kodi repository. Maybe this solves your issue. I can see from the your last log that the issue is related to Developer mode. I would disable it.

dagwieers commented 4 years ago

And it appears the Developer mode is broken. But for normal use you should not enable it anyway.

dagwieers commented 4 years ago

@im85288 Do we still need this Developer mode? I have never used it and it appears broken.

im85288 commented 4 years ago

@dagwieers Yes it’s specifically there for skinners to make their life easier for skinning the windows.

dagwieers commented 4 years ago

@im85288 Ok, can you explain how it is supposed to work? I assume it shows a specific pop-up after X seconds and shows it for the duration of Y seconds?

Why don't we simply show it when an option is pressed from the settings (so without anything being played) ? So rather then a mode, it would be an action showing the pop-up for X seconds.

im85288 commented 4 years ago

@dagwieers It shows the selected pop up (up next/up next simple/still watching/still watching simple) continuously until a button is pressed (skinning takes a lot of testing) and simply uses the game of thrones Fanart.

Not sure how/why you would show them without anything being played without re writing a fair bit of code? From feedback with other skinners I think everyone liked it how it worked prior to being broken.

Prior to having this mode it was extremely difficult to reproduce certain windows (eg still watching)

dagwieers commented 4 years ago

@im85288 Since developer mode doesn't test any of the interactions (correct?), showing the Window for a short time when pressing an option should not be that hard.

So my proposal would be to replace "Developer mode" with:

The implementation would use the existing default.py add-on script, and we would call that script. The script reads out the configured Window setting and shows the appropriate window, until the Back button is pressed (or it times out). Should be fairly simple to implement.

And it would get rid of the confusion from users that enabled Developer mode accidentally :wink:

dagwieers commented 4 years ago

Ok, I see what you mean now. My implementation would not show a countdown etc.

notoco commented 4 years ago

Frankly speaking, by reworking the aura and arcti-zephyr2 skins to meet my family's requirements, I also quickly made skins for UpNext.... and I didn't use the dev option - it didn't always work, often after refreshing the skin disappeared, which required going out and entering the episode again. It would have been much easier to show the window with a command.

im85288 commented 4 years ago

I used it quite substantially myself when implementing the default skin dialogs and didn’t have any issues. @dagwieers I think you now understand what the required output is for this mode. I don’t mind if it’s with/without something playing etc just as long as it provides the same functionality as it did prior to it being broken.

dagwieers commented 4 years ago

@im85288 Alright. I think I can make the countdown work though. We can influence the values from outside quite easily from a loop.

im85288 commented 4 years ago

@dagwieers cool sounds good to me but let’s not make it difficult to invoke. Somewhere nice and simple from the settings is fine. It should also at the worst be in the advanced section but I would prefer it to be kept away from normal settings for the addon as it’s only relevant for skinners. We will also need to update the wiki if it’s moved away from developer mode

dagwieers commented 4 years ago

I have it now as a Developer-tab in the settings.

stathis95194 commented 4 years ago

So this is with 1.0.7 and Venom...Tried it with Seren but behaviour is the same. I get no popup from UpNext....and log file shows these. Is it an addon issue?

2019-12-07 17:04:33.243 T:7818 NOTICE: [service.upnext] Monitor -> Calling autoplayback totaltime - playtime is 40.75 2019-12-07 17:04:33.292 T:7818 NOTICE: [service.upnext] Api -> Got active player {u'jsonrpc': u'2.0', u'id': 1, u'result': [{u'playerid': 1, u'type': u'video', u'playertype': u'internal'}]} 2019-12-07 17:04:33.306 T:7818 NOTICE: [service.upnext] Api -> Getting details of now playing media 2019-12-07 17:04:33.418 T:7818 NOTICE: [service.upnext] Api -> Got details of now playing media {u'jsonrpc': u'2.0', u'id': 1, u'result': {u'item': {u'plotoutline': u'', u'episode': 1, u'season': 4, u'tvshowid': -1, u'label': u'Hexagram 64', u'genre': [u'Drama', u'Thriller'], u'playcount': 1, u'type': u'episode', u'showtitle': u'The Man in the High Castle'}}} 2019-12-07 17:04:33.449 T:7818 NOTICE: [service.upnext] PlayItem -> Fetched missing tvshowid -1 2019-12-07 17:04:33.495 T:7818 NOTICE: [service.upnext] PlaybackManager -> Error: no episode could be found to play next...exiting 2019-12-07 17:04:33.512 T:7818 NOTICE: [service.upnext] Monitor -> Up Next style autoplay succeeded.

dagwieers commented 4 years ago

I guess the problem is that it provides tvshowid with value -1. Which causes Up Next to do a lookup for the TV show in the local Kodi tvshow database. And because that fails it returns -1 again, meaning Up Next has no next episode information, so it can't show a pop-up.

The information provided by Venom doesn't include the next episode. To me that seems a problem with Venom. But since I have no knowledge of Venom, it's probably better to discuss this with the developers of Venom?

im85288 commented 4 years ago

@stathis95194 As venom is not an official kodi addon that does not integrate with the kodi database correctly there’s no support for it. As @dagwieers mentioned you would need to report to the venom developers where they would have to follow the wiki on how to integrate 3rd party addons with this addon.

123Venom commented 4 years ago

I'm sorry but I'm not sure I agree that this is a Venom issue as I myself can use 1.0.1 without issue but any version after that fails with no pop-up notice. Unless I'm unaware of the data passed to UpNext was changed? In the kodi.log for v1.0.1 I get this 2019-12-08 22:20:25.724 T:2988 NOTICE: UP NEXT Api -> log : addon_data_received called with data {"play_info": {"item_id": 2110636}, "next_episode": {"rating": "8.2", "tvshowid": "305574", "art": {"tvshow.fanart": "https://thetvdb.com/banners/fanart/original/305574-7.jpg", "thumb": "https://thetvdb.com/banners/episodes/305574/5579548.jpg", "tvshow.clearart": "https://assets.fanart.tv/fanart/tv/305574/hdclearart/the-crown-582b72f70b029.png", "tvshow.landscape": "https://thetvdb.com/banners/fanart/original/305574-7.jpg", "tvshow.poster": "https://thetvdb.com/banners/posters/305574-3.jpg", "tvshow.clearlogo": "https://assets.fanart.tv/fanart/tv/305574/hdtvlogo/the-crown-5819b8cde1034.png"}, "plot": "With King George too ill to travel, Elizabeth and Philip embark on a four-continent Commonwealth tour. Party leaders attempt to undermine Churchill.", "season": "1", "title": "Hyde Park Corner", "episodeid": 2110637, "tvshowimdb": "tt4786824", "firstaired": "2016", "year": "2016", "episode": "2", "playcount": 0, "showtitle": "The Crown"}, "notification_time": 60, "id": "plugin.video.venom_play_action", "current_episode": {"rating": "7.7", "tvshowid": "305574", "art": {"tvshow.fanart": "https://thetvdb.com/banners/fanart/original/305574-7.jpg", "thumb": "https://thetvdb.com/banners/episodes/305574/5474001.jpg", "tvshow.clearart": "https://assets.fanart.tv/fanart/tv/305574/hdclearart/the-crown-582b72f70b029.png", "tvshow.landscape": "https://thetvdb.com/banners/fanart/original/305574-7.jpg", "tvshow.poster": "https://thetvdb.com/banners/posters/305574-3.jpg", "tvshow.clearlogo": "https://assets.fanart.tv/fanart/tv/305574/hdtvlogo/the-crown-5819b8cde1034.png"}, "plot": "A young Princess Elizabeth marries Prince Philip. As King George VI\u2019s health worsens, Winston Churchill is elected prime minister for the second time.", "season": "1", "title": "Wolferton Splash", "episodeid": 2110636, "firstaired": "2016", "episode": "1", "playcount": 0, "showtitle": "The Crown"}} I've specifically logged the tvshowid and most definitely am passing a valid value.

dagwieers commented 4 years ago

@123Venom The issue that was reported, did not include play_info, next_episode or provided tvshowid as -1. Please provide us with a log that fails, while it does send these things.

Up Next is not going to give a pop-up when it has no information on the next_episode and it has no play_info.