imDaniX / Dangerous-Caves-2

Minecraft Bukkit plugin for a new cave experience
MIT License
22 stars 7 forks source link

Disable Cave Aging Inside Claims #21

Closed HyperVx2 closed 3 years ago

HyperVx2 commented 4 years ago

My players would love to make their bases underground without the cave aging feature inside their claims. Is it possible to hook with GriefPrevention to stop cave aging inside claims?

imDaniX commented 4 years ago

I just tried to add GriefPreventionFlags support into the plugin in latest build. Honestly I'm not sure if it works and persists after restart, but would be awesome if you try it. If you don't want to use another plugin - I'm planning to add flag-less mode, so it will just disable certain features inside of regions.

HyperVx2 commented 4 years ago

Thank you. I'll give it a try soon and will give feedback.

imDaniX commented 4 years ago

Added flagless mode, so you can choose it to disable some of features inside of claims. worldguard-flagless for WorldGuard and griefprevention-flagless for GriefPrevention.

LoneDev6 commented 4 years ago

"[DangerousCaves] Can't find mode "griefprevention". Regions feature is disabled."

I also tried griefprevention-flagless but the aging is still active on griefprevention protected areas.. I use Worldguard for spawn and Griefprevention for user claims, is there a way to add both protections? Please.

Thanks

imDaniX commented 4 years ago

@LoneDev6 You have to use griefprevention-flagless for just GriefPrevention. Anyway, I will look into it. I was already thinking about combined protections. It's actually quite simple to do with current system. Will try to implement it.

LoneDev6 commented 4 years ago

Thanks please let me know. Anyway I triesd also to use griefprevention-flagless without success, as I said

imDaniX commented 4 years ago

@LoneDev6 GP region checker should work properly now. Also renamed griefprevention mode to griefprevention-flags and griefprevention-flagless to griefprevention (and same for WG). Also you can now specify multiple modes, like mode: griefprevention,worldguard

niqoar commented 4 years ago

This continues to happen in griefprevention protections :(

Dangerous Caves 2: v2.2.7 GriefPrevention: 16.14.0

imDaniX commented 4 years ago

@niqoar, can you show list of your modes from the config?

niqoar commented 4 years ago

@niqoar, can you show list of your modes from the config?

Yes, this is my config: https://pastebin.com/vCEENGVm

imDaniX commented 4 years ago

@niqoar, as for now not sure what's wrong. Will look deeper into it a bit later.

imDaniX commented 4 years ago

There were some commits related to this issue. If anyone is interested - please test it.

l3st4tDevelopment commented 4 years ago

My players confirm that the cave aging is mostly gone - except for one thing: the mushrooms.

imDaniX commented 4 years ago

@l3st4tPlugins are you sure that DC causes it and not vanilla mushrooms spreading?

l3st4tDevelopment commented 4 years ago

Not sure. Didn't even know vanilla mushrooms can spread. I guess I could add debug and monitor it.

l3st4tDevelopment commented 3 years ago

After testing, there were some hidden mushrooms in their lands, and removing them fixed it. So at least under the Lands protection, cave aging inside claims is disabled.

imDaniX commented 3 years ago

Will leave this issue open for one more month just in case.

Kenaestic commented 3 years ago

Hi. I'm not sure if this is related to the problem above but I'm getting this warning from the plugin:

[08:19:23 WARN]: [DangerousCaves] Can't find mode "griefprevention".

I also have the same problem as the person above.

imDaniX commented 3 years ago

@Kenaestic It tells that DC2 can't detect GriefPrevention plugin on your server, so mode can't be used - do you actually have GriefPrevention installed? Also, what's your exact second problem?

Kenaestic commented 3 years ago

@Kenaestic It tells that DC2 can't detect GriefPrevention plugin on your server, so mode can't be used - do you actually have GriefPrevention installed? Also, what's your exact second problem?

Yes I'm positive. I also have other plugins hooking into griefprevention like dynmap. I'm on the newest version on both Dangerous Caves and Griefprevention. I tried downgrading versions with both plugins without succes. I suspect it may be a paper update that caused this but I'll have to test it out.

I left my server startup log in the spigot discussion thread but I'll send you an up-to-date one here: https://pastebin.pl/view/0034cc76

DC settings: https://pastebin.pl/view/bbb04e8f

Griefprevention settings: https://pastebin.pl/view/4f2393d7

Let me know if you need anything else.

imDaniX commented 3 years ago

@Kenaestic Seems like somehow DC starts sooner than GP, and that's quite weird.

imDaniX commented 3 years ago

@Kenaestic Please try latest build, it should be fine now.

Kenaestic commented 3 years ago

@Kenaestic Please try latest build, it should be fine now.

I can confirm that I'm not getting any warnings now. I'll test the plugin further and will report back if there's any problems. Thanks for your help 👍

imDaniX commented 3 years ago

Please reopen the issue if something is still doesn't work.