Closed crashkonijn closed 5 years ago
Thank you so much, let me have a look first at this weekend :)
On another note, I would like to add the 'exceptionOccurred' (or queuedForRetry or somehting similar) to show the difference between a job which has failed completely or which is still retrying.
I changed the following:
retrying
state$this->prepareStatus()
on every job.getAllowedStatuses() is unused internally, but used in my application only :) I would rather keep dependencies to minimal.
I will merge this as 1.0 release soon. Will release after finishing some real-world testing on my application. Big thanks to @crashkonijn 👍
Nice, thanks!
Let me know if you run into any problems.
Also, one thing that could use some more testing are the Trackable progress
input
and output
methods. If someone could test those that would be great.
I actually thought of creating a PR in order to allow jobs to have parents. For instance using ::dispatchChild()
would dispatch the job and set a parent_id. What do you think @crashkonijn? Should I make a PR or would you implement it? Might just be a few lines
@mrvnklm as of today I no longer work at Webparking, so personally I don't use this anymore. If there's something that needs fixing in the original PR I'm willing to make those changes, but unfortunately I don't have to time to develop new features.
@crashkonijn no worries, I might make a PR once @imTigger does merge
__DIR__ . '*/*../database/migrations/'
is missing the highlighted slash in LaravelJobStatusServiceProvider.php
@crashkonijn Am I doing something wrong? When I call $job = new TestJob()
, $job->getJobStatusId()
is null and if I try to $job->update([...])
the job dies without exception
Sorry for the delay, it has been tough months in Hong Kong. Will tag a major release soon :)
Understandable, I wish you all the best with that situation!
I am working on a new project myself on Laravel 6 recently with 1.0-rc. Strange thing is the "getJobStatusId()" is actually called before "__sleep()", therefore prepareStatus() call still needed on each Job's constructors.
Hey @imTigger!
Glad to see you survived the Honk Kong crisis so far!
Unfortunately I haven't been using Laravel for 7 months now, so I can't tell you why that's happening.
I do hope you figure it out and can merge this PR, I put a lot of time into it :)
Thank you for your work, it works almost perfectly 👍 This PR has been merged in 1.0 release. I am adding more functionality and fixing CI build for 1.1 release.
Hope you all are staying well too :)
Hi there,
This morning I came up with a better way of handling the improvement that I proposed in #37. While I was at it I also changed the following:
If you choose to accept this PR #36 & #37 can be closed.
Edit; if you enable travis for this project it will test new PR automatically: https://travis-ci.org/webparking/laravel-job-status