imTigger / laravel-job-status

Add ability to track Job progress, status and result dispatched to Queue.
MIT License
407 stars 60 forks source link

Status stay in retrying #53

Open jamalyan opened 4 years ago

jamalyan commented 4 years ago

Hi there. I am trying to use this great package at first time. But I got one issue. When job get exception, the status not changing to 'failed', but stay 'retrying'. In DefaultEventManager I have changed exceptionOccurred method functionality to get what I need.

'status' => ($event->job->attempts() == $event->job->maxTries()) ? $this->getEntity()::STATUS_FAILED : $this->getEntity()::STATUS_RETRYING,

sstankov commented 4 years ago

Just we verify we experienced the same one.

o15a3d4l11s2 commented 3 years ago

Despite the fix I am still getting this issue - if the job fails, status stay as 'retrying', although the job is moved to the failed_jobs table by Laravel and there are no more retries. I think this is also related to #63.

mylemans commented 3 years ago

Despite the fix I am still getting this issue - if the job fails, status stay as 'retrying', although the job is moved to the failed_jobs table by Laravel and there are no more retries. I think this is also related to #63.

Same issue here. Any update on this?

To add, this gets logged in the failed jobs table:

Illuminate\Queue\MaxAttemptsExceededException: Modules\Platform\Jobs\XXX\XXXJob has been attempted too many times or run too long. The job may have previously timed out.

'Causer' of the exception is using the WithoutOverlapping middleware

JuanS commented 2 years ago

Having the same problem here, made a PR https://github.com/imTigger/laravel-job-status/pull/72

mylemans commented 2 years ago

@imTigger Any idea when you'll publish a new release with this fix?

MathiasWeisheit commented 2 years ago

@mylemans what can we do do get the change in a new release?

mylemans commented 2 years ago

@mylemans what can we do do get the change in a new release?

Why are you asking me? ;D

MathiasWeisheit commented 2 years ago

That's right! I already searched for forks with more engagement.