search

imaNNeo / fl_chart

FL Chart is a highly customizable Flutter chart library that supports Line Chart, Bar Chart, Pie Chart, Scatter Chart, and Radar Chart.
https://flchart.dev
MIT License
6.87k stars 1.78k forks source link

Remove remaining `axisTitleData` references #1596

Open JoshMart opened 8 months ago

JoshMart commented 8 months ago

There are old references to the outdated axisTitleData in the docs and in some code comments after it was removed. Two issues were opened to ask about these missing properties: #1259 and #1201. This PR cleans up all remaining code and doc references to axisTitleData.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.52%. Comparing base (930ac12) to head (fa40aaf). Report is 8 commits behind head on main.

:exclamation: Current head fa40aaf differs from pull request most recent head 3d803d8. Consider uploading reports for the commit 3d803d8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1596 +/- ## ======================================= Coverage 87.52% 87.52% ======================================= Files 45 45 Lines 3078 3078 ======================================= Hits 2694 2694 Misses 384 384 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imaNNeo commented 7 months ago

Thank you so much! It's ready to be merged. Please resolve the CHANGELOG conflict first.

JoshMart commented 7 months ago

Thank you so much! It's ready to be merged. Please resolve the CHANGELOG conflict first.

You got it. Conflicts should be resolved now.

imaNNeo commented 6 months ago

Sorry, I just updated the CHANGELOG some minutes ago, so I saw the conflict here again and I tried to fix it. But it seems it isn't fixed, can you please revert your change in the CHANGELOG? I will write it by myself.

imaNNeo commented 1 month ago

Hello? any update?