search

imaNNeo / fl_chart

FL Chart is a highly customizable Flutter chart library that supports Line Chart, Bar Chart, Pie Chart, Scatter Chart, and Radar Chart.
https://flchart.dev
MIT License
6.74k stars 1.74k forks source link

preventCurveOverShooting sounds like mitigation rather than solution #1648

Open chris-rutkowski opened 4 months ago

chris-rutkowski commented 4 months ago

Hey, amazing plugin, please don't get me wrong with this issue.

There are a lot of issues that include the keyword preventCurveOverShooting. It is always suggested to the problem that can be seen on the picture (taken from one of the issues):

Screenshot 2024-05-01 at 9 06 43 PM

But I don't think it is a solution. While it's nice to have a control over "roundness", there shouldn't be preventCurveOverShooting+preventCurveOvershootingThreshold as there shouldn't be any over shooting in the first place. Chart shouldn't display data that doesn't exist.

Those bumps are buggy and glitchy. aboveBarData and belowBarData doesn't colour them when they are rendered beyond bounds. The issue https://github.com/imaNNeo/fl_chart/issues/25 has been closed, despite glitch reported there by @jamesblasco - line has inconsistent thickness when those prevent... are toggled on.

Once again, amazing work, love your plugin, but would kindly appreciate reconsidering this implementation. We just want round lines, not zigzags :)

TobiasRump commented 4 months ago

Yeah it would be a really good idea, to have the preventCurveOverShooting = true as default.

Here is again a user from today, who is confused

https://github.com/imaNNeo/fl_chart/issues/1649