search

imaNNeo / fl_chart

FL Chart is a highly customizable Flutter chart library that supports Line Chart, Bar Chart, Pie Chart, Scatter Chart, and Radar Chart.
https://flchart.dev
MIT License
6.87k stars 1.78k forks source link

Giving users control over min/maxIncluded for axis titles by including them into SideTitles (addresses #906) #1686

Closed sczesla closed 2 months ago

sczesla commented 5 months ago

Including titles (labels) for the minimum and maximum data value is sometimes not desirable (see #906). The iterateThroughAxis routine (in axis_chart_helpers.dart) provides the logic for optional inclusion of the minimum and maximum already. This PR gives users control over these flags by incorporating them into SideTitles.

imaNNeo commented 5 months ago

You haven't used the properties that you defined. I think you need to add them here. Also, please read the contribution guideline carefully, you need to write unit-tests

sczesla commented 5 months ago

Thanks for the feedback!

You haven't used the properties that you defined. I think you need to add them here.

I don't think so. Your link points to the defaults. The values are being used, possibly overwriting those defaults , when iterateThroughAxis is called here

Also, please read the contribution guideline carefully, you need to write unit-tests

Right. I added a test of the effect of setting the parameters when plotting, fixed formatting issues, edited the CHANGELOG, and rebased.

Cheers

imaNNeo commented 2 months ago

Thank you so much for your contribution!