search

imablanco / Zoomy

Zoomy is an easy to use pinch-to-zoom Android library
918 stars 120 forks source link

Dialog Fragment #2

Closed TurKorsaN closed 6 years ago

TurKorsaN commented 7 years ago

When using in DialogFragment, ZoomableView stays under DialogFragment. And i can't see the image.

imablanco commented 7 years ago

The library uses Activity's decor view to place the target view on top of everything but Dialogs in Android are shown creating another Window above current the current one. I will try to figure out how to resolve this issue. If someone has any idea how to deal with this any help will be appreciated.

TurKorsaN commented 7 years ago

I made my own implementation but I didn't tested it very well.

imablanco commented 7 years ago

Feel free to make a pull request then.

Zachinio commented 6 years ago

Have you overcome this issue?

LawrenceStent commented 6 years ago

Do you have a solution for this yet? Rather important to have this working if I'm to use it in our project.

imablanco commented 6 years ago

@ZachBublil @LawrenceStent Sorry but I have no time right now to handle any issues. @TurKorsaN mentioned that he managed to resolve it, so maybe he can offer some help

LawrenceStent commented 6 years ago

It's fine I changed my implementation to the of a normal fragment. If anyone else is looking at this then this is an option, however having a zoom on a dialog may not be possible with this library.

imablanco commented 6 years ago

Hi everyone I managed to solve the issue partially by drawing the zoomed View over the Dialog's window, but because of the nature of them, depending on their window configuration, they may be drawn on not-full screen windows, so the zoomed View will never scale over the whole screen in these cases. Fullscreen Dialogs tested works well.

akshitpsutariya commented 4 years ago

The library uses Activity's decor view to place the target view on top of everything but Dialogs in Android are shown creating another Window above current the current one. I will try to figure out how to resolve this issue. If someone has any idea how to deal with this any help will be appreciated.

I have faced the same problem

imablanco commented 4 years ago

Hi @akshitpsutariya you should be able to construct the Zoomy builder with a Dialog instance to get the decor view from its Window.