search

imabug / raddb

Radiology equipment inventory tracker
MIT License
1 stars 1 forks source link

Possible fix for some surveys not displaying as cyan when due within 30 days #807

Closed scythe closed 6 months ago

scythe commented 6 months ago

Requirements

One-line change, should merge easily.

Description of the Change

When looking at the survey status, I noticed that some surveys which are due in less than a month were not displaying in cyan as expected.

In views/dashboard/test_status.blade.php, there is an if-elseif-else cond check which proceeds <355, >=335 && < 365, >=365 && <395.... This appears to be a typo since the first and second conditions are not mutually exclusive.

Alternate Designs

N/A

Why Should This Be In Core?

Bugfix is likely necessary to obtain the intended functionality.

Benefits

Helps easily see which surveys are coming due.

Possible Drawbacks

Needs to be tested.

Applicable Issues

N/A, bug fixed immediately when issue discovered.

imabug commented 6 months ago

Thanks, good catch. At some point this should probably be refactored to move the logic out of the view.