search

imacrayon / eventsinwichita

Just Events in Wichita, nothing else.
https://eventsinwichita.com
MIT License
11 stars 6 forks source link

Allow admins to filter by unapproved & deleted events #27

Closed R3l4x3 closed 4 years ago

R3l4x3 commented 4 years ago

I changed something about merging the array to the request. So I can omit the 'before' and 'after' filters if another filter is selected.

I noticed that not only admins can see the 'trashed' and 'unapproved' events. Is that intentional? If not, I can also take a look at it and solve it in another PR. :)

I also changed how the query parameters are retrieved from the request. See also:

Cloeses #22

imacrayon commented 4 years ago

This all looks great! I’ll take a closer look and try to merge it this evening. Thanks for catching that get too.

You can submit a PR for those permissions issues if you’d like. Is not the end of the world if users see those, but I think you’re right, trashed events should only be visible for admins.