imacrayon / eventsinwichita

Just Events in Wichita, nothing else.
https://eventsinwichita.com
MIT License
11 stars 6 forks source link

Add meta data for Events #31

Closed imacrayon closed 4 years ago

imacrayon commented 4 years ago

Additional meta data on single event pages would be nice so that more info is provided when a like to an event is shared on social media/in slack maybe we should use vue-meta to make this easy.

thebatclaudio commented 4 years ago

Hello, can I try to do this?

imacrayon commented 4 years ago

Yep!

thebatclaudio commented 4 years ago

Are you sure that vue-meta is the right choice? I think that we need a server side rendering, but vue-meta is client-side.

imacrayon commented 4 years ago

The front-end is build is build with Inertia.js, so it's essentially a SPA. But you make a good point - I wonder if many services will be able to pull the meta info if JavaScript has to load first? I'm not sure if there's a way to edit the the meta data in the app.blade.php and still use Inertia.

imacrayon commented 4 years ago

Nvm, the bottom of this page has meta tag examples: https://inertiajs.com/responses . I think that might be the way to go.

thebatclaudio commented 4 years ago

Hi @imacrayon, I think that I will proceed in this way:

What do you think?

imacrayon commented 4 years ago

That sounds good to me 🙂

thebatclaudio commented 4 years ago

I made a pull request for this: #34 I added only title and description in event's single page because I don't know exactly what metatags I have to show. If you want you can tell me and I will add them!

imacrayon commented 4 years ago

Fixed in #34