image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Knob pick up problems again #133

Closed RDPRDP closed 2 years ago

RDPRDP commented 2 years ago

I thought I had all issues revolved, but tonight I had problems picking up OCS A Gain/Vol.

matrix12x commented 2 years ago

Did you have the issue with OSC A volume in GLIGLI panel mode or SCI panel mode? "From tape" + 6 switches between these modes (pages 47-48 of new manual)

RDPRDP commented 2 years ago

On GLIGLI, which is what I normally use. I've been able to find a single patch that gives me this issue. I can go back and forth between this patch and another, and while the other works, this specific patch will always give the same issue. I'd upload the SYSEX, but I'm having trouble finding something to send a SYSEX REQUEST command to the synth so I can record the single SYSEX (not a problem) and attach it for you to try if you like. I'm on OSX.

matrix12x commented 2 years ago

If you press "from tape" + Record, "Preset" will be flashing. Then press the patch number (e.g., 05 or 11 or whatever), it dumps the patch. I use the program C6 on my mac to send and receive sysex.

RDPRDP commented 2 years ago

I switched my interface over to my PC to try the dump. Hopefully this is the right patch. I'll move back to my OSX setup and send it back.

Note: Thanks for letting me know single dump is available, I was using the SYSEX solution here!

https://gearspace.com/board/showpost.php?p=15778152&postcount=3116

OSCGAINv2.zip UPDATED file (V2) attached.

matrix12x commented 2 years ago

edit - deleted post

RDPRDP commented 2 years ago

Just to note, please ensure to use V2 now updated in my initial attachment post. The first wasn't the right patch.

matrix12x commented 2 years ago

Thanks. Just did that. V2 works in the patch parameter converter. I was trying to look at the parameter values before loading it into my P600 for testing.

Might it be a corrupt patch? If it is the only patch that has the bug, it may not be an OS bug. Either way I'll check it out.

RDPRDP commented 2 years ago

V1 was probably some user error as I had quickly jumped over to MIDI-OX on my PC and just wildly tried to obtain a result, without really knowing the full intricacies of the software. For V2 I reverted back to my Mac, and used your single dump command from the P600 panel. Now, if there is possibility for an error, maybe it's in the situation where a SYSEX REQUEST is sent, as that is how I accomplished V1. The command was: F0 00 61 16 02 03 F7 (Patch located in memory 03).

Jpro600k commented 2 years ago

I checked your preset file Program 03 V2. Layout : Results SCI layout OSC A Knob : Mixer Gligli Layout : Volume Following the layout change, it switched normally.

In the SCI layout, the OSC A knob plays the same MIXER role as the original system, so you may feel that the volume adjustment is gone. No matter how many times I switch, it switches normally.

matrix12x commented 2 years ago

I confirm for RDP's patch above, I could not get pick up to on OSC A volume to work (it would never pick up the pot position/value), only in the case where I had "to tape" already on when I tweaked the knob. However, if I loaded the patch and had the "to tape" light off, the knob picked up fine and chnages to OSC A volume worked as expected (same patch).

If I started with the "to Tape" led on, pickup would not happen for VCO A volume, but if I turned "to tape" off and on again, then it picked up fine and then that patch would never have that issue again. I was able to repeat this consistently.

I'm not sure if it is a patch bug, or a coding bug. @RDPRDP was this patch made in a prior Alpha? (not then current Alpha 14), if so, that may explain the issue.

RDPRDP commented 2 years ago

Glad to see you were able to reproduce my issue!

I've read your notes a few times, and am possibly confused on how things work. For me as well, if I do not have "TO TAPE" selected I can change the values without issue, but my thinking is this works as pickup mode is not engaged, and the value just jumps to the current value, in the same manner the synth operated before we ever got into trying to achieve a pick-up mode? In other words, if "TO TAPE" is not selected, you should never have an issue, as the routine is not engaged trying to resolve your position against the memory position.

I also tried your solution/finding: Turn "TO TAPE" on, then off (without changing the pot!!!!), then on again, but for me, I am unable to get the pickup to work, the outcome is the same.

fun fun fun

RDPRDP commented 2 years ago

I forgot to answer: I'm not sure when I created this patch, but pretty sure it was a prior Alpha. Probably quite a versions old. Too bad patch SYSEX doesn't capture the HOST OS.

image-et-son commented 2 years ago

I forgot to answer: I'm not sure when I created this patch, but pretty sure it was a prior Alpha. Probably quite a versions old. Too bad patch SYSEX doesn't capture the HOST OS.

The storage version should be sufficient in terms of capturing context info. When you use the script to see the values stored in the patch then this is what is used inside the P600 no matter what the OS state was it was created in. No other/hidden information that affects the behaviour.

I will try to reproduce the bug. I will first look at the values of vol A and vol B in the patch. In my very first attempt of pick-me-up there were pots I couldn't pick up because the value was too large for the accuracy of the pot scanning. While I fixed that it might be a similar constellation.

Tested: bug confirmed. Funny little thing and curious. Thanks for detecting it! And: it has nothing to do with the value being somewhere where it can't be picked up. But I will find it...

image-et-son commented 2 years ago

The value of Vol A in this patch is an edge case for the pot reading accuracy for these pots. In this constellation it can happen that the proximity requirement for "pick up" is too narrow. I widened the puck up band and it works now smoothly. This should solve all other pots for which this could in principle happen. Thanks for finding this bug!