search

image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Feature request: LFO synced divisor, and phase offset #135

Open RDPRDP opened 2 years ago

RDPRDP commented 2 years ago

When sync'ing to MIDI, it would be nice to control the LFO so:

  1. You can set the start phase on trigger/reset of the LFO shape.
  2. The speed dial works on divisors of the MIDI clock for the LFO. Maybe also retain the current RATE as well, though an option switch?
image-et-son commented 2 years ago

Hi, when you sync clock to external MIDI then the data/speed dials already sets the MIDI clock divider (instead of speed), so it also affects the LFO if the LFO is set to be sync'ed to seq/arp clock. Have you tried that? See manual :-)

BTW: at the moment LFO sync is only active if arp and/or seq is running. Is there a case for having LFO sync'ed to external MIDI also if there is no arp or seq running?

The LFO phase is be a new feature, but as a feature request it is pretty clear.

image-et-son commented 2 years ago

@RDPRDP: Hi, have you had a chance to look at my comments and questions relating to your feature request?

RDPRDP commented 2 years ago

@image-et-son I believe we completed the conversation here: https://gearspace.com/board/showpost.php?p=15888843&postcount=3468 .

To clarify, I would be very happy to have a solution to play a midi sequence from my computer, with or without MIDI clock running (so trigger can be either note on, or on a clock ON/sync), or on the P600 keyboard directly, but without the ARP or Sequencer necessarily running. This permits a guaranteed response from the LFO in regards to the set trigger. A great usage of this would be if we ever move to more expanded LFO shapes as per the Martix12x builds. Even now with the stock LFO shapes it is still useful. For instance, you can have filter action (LFO to FLITER) that is repeatable (you know what the response will be. I had a jam session a few weeks ago where I knew the tempo of who I was playing with (their drum machine was setting the tempo), and I wanted to have some repeatable filter aciton when I was playing (just playing, no ARP or sequencer), but the LFO is free running, so the filter action was not aligned with the trigger in this scenario, which was note on. I'm not saying this is the only scenario.

image-et-son commented 2 years ago

OK, understood.

If this feature request gets to be selected I would need to think if the clock can always run and how/where a new phase parameter can be implemented.

image-et-son commented 1 year ago

Hi @RDPRDP: I am in the process of sweeping up all the ideas and requests. After this discussion I had already introduced the LFO Sync option "key", where the LFO is retriggered with a new note (when no note is held). This is a feature of v2022. That covers half of the story, I guess.

So I figure there are three residual ideas, right?

RDPRDP commented 1 year ago

Hello! Yes, that is all right. The only modification might be (maybe this variable is covered):

change to:

And maybe a CC or another source to modulate the phase offset! Oh....... that sounds interesting! Beyond scope I think.....

And having the extra Martix12x LFO shapes back would be a bonus!

thanks again! Robert

On Wed, Sep 21, 2022 at 7:11 PM imogen @.***> wrote:

Hi @RDPRDP https://github.com/RDPRDP: I am in the process of sweeping up all the ideas and requests. After this discussion I had already introduced the LFO Sync option "key", where the LFO is retriggered with a new note (when no note is held). This is a feature of v2022. That covers half of the story, I guess.

So I figure there are three residual ideas, right?

  • Parameter for setting the phase offset
  • Having the internal clock running also without arp/seq running so that LFO can be sync'ed to it
  • Combination of "on key" LFO trigger with LFO sync to clock?

— Reply to this email directly, view it on GitHub https://github.com/image-et-son/p600fw/issues/135#issuecomment-1253492063, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBSRXGCPVMADXKAE5NF52TV7LNNHANCNFSM5QBENUVA . You are receiving this because you were mentioned.Message ID: @.***>