image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Diverse corrections and imrpovements of v2022 #196

Closed image-et-son closed 2 years ago

image-et-son commented 2 years ago

From Dioskilos (https://gearspace.com/board/showpost.php?p=16179440&postcount=3933):

In the "Section 3.14 Pitch bender" section of the documentation, it states:

The range of the bender can be configured using the additional patch parameter (66) Bender Range. It offers the choices 2nd (bend a full tone), 3rd (bend 3 semi-tones), 5th (bend 5 semi-tones) and octave (bending an entire octave).

But this should be corrected to state the proper amount of semi-tones in a 3rd and 5th:

The range of the bender can be configured using the additional patch parameter (66) Bender Range. It offers the choices 2nd (bend a full tone), 3rd (bend 4 semi-tones), 5th (bend 7 semi-tones) and octave (bending an entire octave).


In the "3.6 Envelopes and routing" section of the documentation, it states: slow - linear slow - exponential fast - linear fast - exponential

Then in the "Reference 5.1 Patch parameter overview" section of the documentation for the 5 Envelope has these listed for Filter Envelope Shape and 2nd Envelope Shape, it states: fast-lin fast-exp slow-lin slow-exp

But then the synth display shows: lin-slow exp-slow lin-fast exp-fast

For consistency, it would be nice to adjust the documentation in 3.6 and 5.1 to match what is in the synth.


In the "Reference 5.1 Patch parameter overview" section of the documentation it states:

1 LFO Shape tri-square, sin-random, saw-noise

But documentation should be:

1 LFO Shape tri-pulse, sin-random, saw-noise

Also...

1 LFO Clock Sync

...should be listed in documentation as...

LFO Trigger

Finally, the listed parameters in the documentation for the LFO Clock Sync/Trigger are: off, key, 1, 2, 3, 4, 5, 6, 8

But the synth only has these parameters available: off, key, 1, 2, 3, 4, 5, 6

So either the documentation needs to be updated to remove the 8 or the synth software should be updated to include the 8.


In the "Reference 5.1 Patch parameter overview" section of the documentation...

3 "Modulation Target" should be updated in documentation to say "Modulation Wheel Target"


In the "Reference 5.1 Patch parameter overview" section of the documentation...

6 Bender Target documentation lists these options: off, VCO, VCF, amp

But the synth has these options: off, AB, VCF, Volume, B

So the documentation should be updated to reflect what is available in the synth.


In the "Reference 5.1 Patch parameter overview" section of the documentation...

All references to "numeric 0...98" should be updated to "0...99" because the values in the synth can all go to 99.


And lastly...

In the synth display, there is 333 "MOD RNG" for modulation wheel range and 66 "BEND RAN" for bender range. I think that 66 "BEND RAN" should be reprogrammed to display 66 "BEND RNG" for consistency.

image-et-son commented 2 years ago

All changes implemented except for the LOF Sync value "8" issue. This is tracked separately.