image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Speed not stored / recalled correctly after power cycle #54

Closed image-et-son closed 2 years ago

matrix12x commented 2 years ago

This bug existed in my versions as well. Honestly I could not get it to recall speed with the patch. The bug probably exists in GliGli's original code.

Also, I don't think Arp/seq speed should be a patch level parameter. Because if it was, then when you change patches, arp/seq speed would change. So imagine you are playing a patch with the sequencer playing, and you go to audition different patches with that seq, if speed was a patch level parameter, then the speed would change.

On my unit on Alpha 9 (and on previous) speed always starts at zero on power on. Edit: fixed typo "monad" should have been "and on"

image-et-son commented 2 years ago

Finally found it. There were some remnants of the speed parameter as part of the patch and the transfer of the parameter to a settings parameter was only half implemented.

el-folie commented 2 years ago

Tested - works - done.