search

image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Feature Request: add VCA as Vibrato LFO modulation target #61

Closed matrix12x closed 2 years ago

matrix12x commented 2 years ago

New Vibrato LFO target: VCA

see my old code

matrix12x commented 2 years ago

Alpha 11, this works, but maybe needs to be "stronger"

edit: I suggest changing line 1204 in synth.c to match the LFO VCA mod: ampLfoVal+=synth.vibrato.output-(synth.vibrato.levelCV>>1);

image-et-son commented 2 years ago

Absolutely agree, and the same is true for the VCA target of the LFO. This is why I propose to introduce a strength parameter for VCA target for LFO (because of backward compatibility, otherwise I'd be happy to increase is flat).

For vibrato I'll add a factor of 2 and we'll see if that is sufficient.

BTW: the vibrato contribution is already a factor of 2 stronger than the LFO, the function is: ampLfoVal+=(synth.vibrato.output<<1)-(synth.vibrato.levelCV);

matrix12x commented 2 years ago

Alpha 12 hot fix: Vibrato to VCA sounds good. on my unit it can get down to silence, which I like.

image-et-son commented 2 years ago

Thanks for testing. And yes, I have rewritten it such that it covers the entire value range :-) but I had to build in a cut-off so that additional variation does nothing if maxed out. I'll close this. If you find something odd or wrong we can open a new issue.