search

image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Speed dial to clock/speed on start-up and patch selection by dial (in preset panel mode) #72

Closed image-et-son closed 2 years ago

matrix12x commented 2 years ago

I confirm that on Alpha 11 this works. on boot in manual mode speed knob is speed. I press "preset" and speed knob defaults to patch selection. of note if I hit "to tape" then go to manual mode, it stays as if "to tape" was still lit. not sure if this is intended

Edit (bug found): in preset mode, I moved the filter knob (for example) I got the edit dot appeared like normal. However while speed knob was in patch selection, the edit dot stayed lit while I selected patches, I think it should turn off once a new patch number is selected.

Note: I love how quick it is to dial up patches and I don't feel like I will wear out the membrane switches with extra presses.

image-et-son commented 2 years ago

Thanks for testing thins. It is inevitable that new UI bugs appear when something like this is introduced. I'll fix the issues you found.

Note: when you change the preset using the number pad then the selection is saved to the settings, so that it is "remembered" in the next power up. Since your are cycling through patches using the dial, I decided to remove the save function there, because I feel it is "irresponsible" to be writing to flash that much for nothing. I also removed the same function when changing the preset using MIDI, for the same reason.

matrix12x commented 2 years ago

I agree that changing presets via midi and the knob should not write to flash (I.e., should not save the selection). I just think we should clear the "dot" in both cases.

image-et-son commented 2 years ago

I confirm that on Alpha 11 this works. on boot in manual mode speed knob is speed. I press "preset" and speed knob defaults to patch selection. of note if I hit "to tape" then go to manual mode, it stays as if "to tape" was still lit. not sure if this is intended

I could not reproduce this. But maybe I didn't the exact thing that you did. Can you please clarify? (the code is such that things like this can easily slip in, sometimes with unpredictable outcome, sometime miraculously doing nothing bad...)

matrix12x commented 2 years ago

Good news, I can't get the bug I noted above to replicate today. at all, under any circumstance. Who knows what actually happened.