image-et-son / p600fw

GliGli based Prophet 600 firmware upgrade
10 stars 4 forks source link

Reduce the number of manual page stores #83

Closed image-et-son closed 2 years ago

image-et-son commented 2 years ago

Currently manual parameters are stored every time a new menu parameter is selected. This could be reduced to after a value CHANGE of a different menu parameter. E.g. when a parameter is changed the OS has a flag that says: store it when ever another parameter is changed. In this way the number of storage operations could be strongly reduced.

image-et-son commented 2 years ago

Now it works as follows: the store is done not when another menu parameter is selected but only the first time this parameter is actually changed. This should reduce the number of stores by about 3 with minimal impact on user convenience. This is more important now with many 3rd press parameters.

matrix12x commented 2 years ago

What is the best way for me to test this? Should I just change a parameter in manual mode such as vibrato speed, then change vibrato target switch to preset and back and see if speed and target stored?

image-et-son commented 2 years ago

The behaviour has changed slightly for the user: before the live patch was stored:

With the new version it is stored:

The consequence for a user is that the last change menu parameter is always lost WHEN SWITCHING OFF. When you change to preset mode it is still stored.

Maybe you could check and assess the situation? What I can do is to monitor the storage execution to confirm the new storage logic from that perspective.

image-et-son commented 2 years ago

From the storage perspective it works as designed. I guess we can close this and leave the assessment of whether this is a good /acceptable idea to the beta testing phase.

matrix12x commented 2 years ago

I confirm it works as explained above.