Open microshine opened 2 years ago
Thanks for the PR! Can you please remove the second commit? Our repositories expect npm7+ to be present (peer dependencies are installed automatically with it).
I'll have a closer look at the code in a few days, as the implementation is quite different than the one I did in image-js
: https://github.com/image-js/image-js/blob/5811f5b7e7677cdda1d8ac124a5c963812e5cd59/src/image/core/load.js#L99-L124
@targos Thanks. Waiting for your review.
Can you please remove the second commit?
Done
But in my case, it breaks lint
tests
https://github.com/microshine/fast-png/runs/4118047939?check_suite_focus=true
Merging #23 (0ae308d) into master (bdb81f9) will increase coverage by
0.11%
. The diff coverage is92.10%
.
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 90.57% 90.68% +0.11%
==========================================
Files 6 6
Lines 403 440 +37
Branches 79 86 +7
==========================================
+ Hits 365 399 +34
- Misses 38 41 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/types.ts | 100.00% <ø> (ø) |
|
src/index.ts | 93.61% <92.10%> (-6.39%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bdb81f9...0ae308d. Read the comment docs.
Can you please remove the second commit?
Done
But in my case, it breaks
lint
testshttps://github.com/microshine/fast-png/runs/4118047939?check_suite_focus=true
The Prettier errors can be fixed with npm run prettier-write
@targos Thank you for the advice. I fixed it
Hi.
I added
rgb
method toindex.js
file. It allows converting indexed data into RGB dataExample of usage