search

image-js / fast-png

PNG image decoder and encoder written entirely in JavaScript
MIT License
329 stars 17 forks source link

Correctly decode non-ASCII tEXt chunks and support encoding them #39

Closed targos closed 6 months ago

targos commented 6 months ago

Refs: https://github.com/image-js/fast-png/issues/26

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (395ecee) 91.54% compared to head (c645b96) 92.20%.

:exclamation: Current head c645b96 differs from pull request most recent head 58b383c. Consider uploading reports for the commit 58b383c to get more accurate results

Files Patch % Lines
src/helpers/crc.ts 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== + Coverage 91.54% 92.20% +0.65% ========================================== Files 9 10 +1 Lines 426 462 +36 Branches 84 87 +3 ========================================== + Hits 390 426 +36 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

targos commented 6 months ago

I'm working on the encoder.

targos commented 6 months ago

Done. I removed keyword-specific character validation because the spec says that decoders should be lenient: https://www.w3.org/TR/png/#13Text-chunk-processing