search

image-js / image-js-typescript

Temporary repository to work on the migration of image-js to TypeScript
https://image-js.github.io/image-js-typescript/
MIT License
5 stars 5 forks source link

feat: RoiMap could too easily contain over 2^15 rois #388

Closed lpatiny closed 1 year ago

lpatiny commented 1 year ago

In order to solve this issue we are using Int32Array instead of Int16Array typed array

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% :warning:

Comparison is base (ecab15e) 98.65% compared to head (7cee7cc) 98.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #388 +/- ## ========================================== - Coverage 98.65% 98.64% -0.02% ========================================== Files 224 224 Lines 5815 5817 +2 Branches 1226 1226 ========================================== + Hits 5737 5738 +1 - Misses 75 76 +1 Partials 3 3 ``` | [Files Changed](https://app.codecov.io/gh/image-js/image-js-typescript/pull/388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=image-js) | Coverage Δ | | |---|---|---| | [src/roi/RoiMapManager.ts](https://app.codecov.io/gh/image-js/image-js-typescript/pull/388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=image-js#diff-c3JjL3JvaS9Sb2lNYXBNYW5hZ2VyLnRz) | `100.00% <ø> (ø)` | | | [src/roi/fromMask.ts](https://app.codecov.io/gh/image-js/image-js-typescript/pull/388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=image-js#diff-c3JjL3JvaS9mcm9tTWFzay50cw==) | `100.00% <100.00%> (ø)` | | | [src/roi/waterShed.ts](https://app.codecov.io/gh/image-js/image-js-typescript/pull/388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=image-js#diff-c3JjL3JvaS93YXRlclNoZWQudHM=) | `100.00% <100.00%> (ø)` | | | [test/testUtils.ts](https://app.codecov.io/gh/image-js/image-js-typescript/pull/388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=image-js#diff-dGVzdC90ZXN0VXRpbHMudHM=) | `97.50% <100.00%> (-2.50%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.