Closed EscapedGibbon closed 2 months ago
I didn't expect the generator to be a private method. I thought we discussed:
.points(kind)
generator function.absolutePoints
getter with cache.relativePoints
getter with cacheI didn't expect the generator to be a private method. I thought we discussed:
.points(kind)
generator function.absolutePoints
getter with cache.relativePoints
getter with cache
We decided that it would be easier that the generator would treat both cases for absolute and relative coordinates. And since the code for both getters became similar, we decided to put it into one getter with a parameter that lets the user choose what kind of coordinates one wants. The coordinates are still cached separately though.
We decided that it would be easier that the generator would treat both cases for absolute and relative coordinates.
That is not contradicting what @targos said. The point is that it should not be private.
And since the code for both getters became similar, we decided to put it into one getter with a parameter that lets the user choose what kind of coordinates one wants.
It's no longer a "getter" if it takes parameters. Let's go with the initial idea: relativePoints
and absolutePoints
getters. Otherwise we would have to find another name to differentiate the generator from the function returning the cached points.
API SGTM but the documentation explanations related to the new fields don't seem clear enough to me. We should discuss it IRL.
I wrote "Images/Masks" instead of "RoiMap" for absolute coordinates because RoiMap doesn't have origin
property.
close: https://github.com/image-js/image-js-typescript/issues/469